Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/222262
Change subject: Enable PHPCS sniff Generic.Files.EndFileNewline
......................................................................
Enable PHPCS sniff Generic.Files.EndFileNewline
Change-Id: Iee3fbf2844fa00af4eb40a25349459f573c24684
---
M client/WikibaseClient.i18n.magic.php
M client/includes/store/sql/PagePropsEntityIdLookup.php
M lib/includes/StringNormalizer.php
M lib/includes/store/BadRevisionException.php
M lib/includes/store/ChunkAccess.php
M lib/includes/store/StorageException.php
M lib/tests/phpunit/Validators/AlternativeValidatorTest.php
M lib/tests/phpunit/Validators/CompositeValidatorTest.php
M lib/tests/phpunit/Validators/DataFieldValidatorTest.php
M lib/tests/phpunit/Validators/DataValueValidatorTest.php
M lib/tests/phpunit/Validators/RegexValidatorTest.php
M lib/tests/phpunit/Validators/StringLengthValidatorTest.php
M lib/tests/phpunit/Validators/TypeValidatorTest.php
M lib/tests/phpunit/store/ChunkCacheTest.php
M phpcs.xml
M purtle/init.mw.php
M repo/ExampleSettings.php
M repo/includes/ChangeOp/ChangeOpQualifierRemove.php
M repo/includes/DataTypeSelector.php
M repo/includes/Hooks/EditFilterHookRunner.php
M repo/includes/LinkedData/HttpAcceptNegotiator.php
M repo/includes/LinkedData/HttpAcceptParser.php
M repo/includes/Notifications/DatabaseChangeTransmitter.php
M repo/includes/Notifications/HookChangeTransmitter.php
M repo/includes/Validators/EntityValidator.php
M repo/includes/actions/HistoryItemAction.php
M repo/includes/actions/HistoryPropertyAction.php
M repo/includes/actions/SubmitItemAction.php
M repo/includes/actions/SubmitPropertyAction.php
M repo/includes/actions/ViewItemAction.php
M repo/includes/actions/ViewPropertyAction.php
M repo/includes/api/ApiHelperFactory.php
M repo/tests/phpunit/includes/ChangeOp/ChangeOpSiteLinkTest.php
M repo/tests/phpunit/includes/Hooks/EditFilterHookRunnerTest.php
M repo/tests/phpunit/includes/api/PermissionsTestCase.php
35 files changed, 38 insertions(+), 36 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/62/222262/1
diff --git a/client/WikibaseClient.i18n.magic.php
b/client/WikibaseClient.i18n.magic.php
index 99b389f..ddfb492 100644
--- a/client/WikibaseClient.i18n.magic.php
+++ b/client/WikibaseClient.i18n.magic.php
@@ -180,4 +180,4 @@
'noexternallanglinks' => array( 0, '隱藏跨語言連結' ),
'property' => array( 0, '屬性' ),
'wbreponame' => array( 0, 'wb報表名稱' ),
-);
\ No newline at end of file
+);
diff --git a/client/includes/store/sql/PagePropsEntityIdLookup.php
b/client/includes/store/sql/PagePropsEntityIdLookup.php
index cedc761..847faaf 100644
--- a/client/includes/store/sql/PagePropsEntityIdLookup.php
+++ b/client/includes/store/sql/PagePropsEntityIdLookup.php
@@ -90,4 +90,5 @@
return reset( $entityIds ) ?: null;
}
-}
\ No newline at end of file
+
+}
diff --git a/lib/includes/StringNormalizer.php
b/lib/includes/StringNormalizer.php
index 1fde79f..d1d7b38 100644
--- a/lib/includes/StringNormalizer.php
+++ b/lib/includes/StringNormalizer.php
@@ -120,5 +120,4 @@
return $this->cleanupToNFC( $this->trimWhitespace( $inputString
) );
}
-
-}
\ No newline at end of file
+}
diff --git a/lib/includes/store/BadRevisionException.php
b/lib/includes/store/BadRevisionException.php
index b80658f..09ac27d 100644
--- a/lib/includes/store/BadRevisionException.php
+++ b/lib/includes/store/BadRevisionException.php
@@ -11,4 +11,4 @@
*/
class BadRevisionException extends StorageException {
-}
\ No newline at end of file
+}
diff --git a/lib/includes/store/ChunkAccess.php
b/lib/includes/store/ChunkAccess.php
index e9de95f..72821db 100644
--- a/lib/includes/store/ChunkAccess.php
+++ b/lib/includes/store/ChunkAccess.php
@@ -33,4 +33,4 @@
*/
public function getRecordId( $rec );
-}
\ No newline at end of file
+}
diff --git a/lib/includes/store/StorageException.php
b/lib/includes/store/StorageException.php
index b8db7f7..8681cb6 100644
--- a/lib/includes/store/StorageException.php
+++ b/lib/includes/store/StorageException.php
@@ -40,4 +40,4 @@
return $this->status;
}
-}
\ No newline at end of file
+}
diff --git a/lib/tests/phpunit/Validators/AlternativeValidatorTest.php
b/lib/tests/phpunit/Validators/AlternativeValidatorTest.php
index d3e9b01..cbb4f7b 100644
--- a/lib/tests/phpunit/Validators/AlternativeValidatorTest.php
+++ b/lib/tests/phpunit/Validators/AlternativeValidatorTest.php
@@ -53,4 +53,4 @@
}
}
-}
\ No newline at end of file
+}
diff --git a/lib/tests/phpunit/Validators/CompositeValidatorTest.php
b/lib/tests/phpunit/Validators/CompositeValidatorTest.php
index 450fb41..dbb16d8 100644
--- a/lib/tests/phpunit/Validators/CompositeValidatorTest.php
+++ b/lib/tests/phpunit/Validators/CompositeValidatorTest.php
@@ -58,4 +58,4 @@
}
}
-}
\ No newline at end of file
+}
diff --git a/lib/tests/phpunit/Validators/DataFieldValidatorTest.php
b/lib/tests/phpunit/Validators/DataFieldValidatorTest.php
index e757637..d6871e3 100644
--- a/lib/tests/phpunit/Validators/DataFieldValidatorTest.php
+++ b/lib/tests/phpunit/Validators/DataFieldValidatorTest.php
@@ -58,4 +58,4 @@
}
}
-}
\ No newline at end of file
+}
diff --git a/lib/tests/phpunit/Validators/DataValueValidatorTest.php
b/lib/tests/phpunit/Validators/DataValueValidatorTest.php
index 4daf09f..7d68c2c 100644
--- a/lib/tests/phpunit/Validators/DataValueValidatorTest.php
+++ b/lib/tests/phpunit/Validators/DataValueValidatorTest.php
@@ -53,4 +53,4 @@
}
}
-}
\ No newline at end of file
+}
diff --git a/lib/tests/phpunit/Validators/RegexValidatorTest.php
b/lib/tests/phpunit/Validators/RegexValidatorTest.php
index f4104ce..d6b33f5 100644
--- a/lib/tests/phpunit/Validators/RegexValidatorTest.php
+++ b/lib/tests/phpunit/Validators/RegexValidatorTest.php
@@ -47,4 +47,4 @@
}
}
-}
\ No newline at end of file
+}
diff --git a/lib/tests/phpunit/Validators/StringLengthValidatorTest.php
b/lib/tests/phpunit/Validators/StringLengthValidatorTest.php
index c5a963c..e48cc6d 100644
--- a/lib/tests/phpunit/Validators/StringLengthValidatorTest.php
+++ b/lib/tests/phpunit/Validators/StringLengthValidatorTest.php
@@ -49,4 +49,4 @@
}
}
-}
\ No newline at end of file
+}
diff --git a/lib/tests/phpunit/Validators/TypeValidatorTest.php
b/lib/tests/phpunit/Validators/TypeValidatorTest.php
index 4795f60..3e360cc 100644
--- a/lib/tests/phpunit/Validators/TypeValidatorTest.php
+++ b/lib/tests/phpunit/Validators/TypeValidatorTest.php
@@ -52,4 +52,4 @@
}
}
-}
\ No newline at end of file
+}
diff --git a/lib/tests/phpunit/store/ChunkCacheTest.php
b/lib/tests/phpunit/store/ChunkCacheTest.php
index 46650a4..e0e4df3 100644
--- a/lib/tests/phpunit/store/ChunkCacheTest.php
+++ b/lib/tests/phpunit/store/ChunkCacheTest.php
@@ -126,4 +126,5 @@
$this->assertEquals( $expected, $chunk, $info );
}
}
-}
\ No newline at end of file
+
+}
diff --git a/phpcs.xml b/phpcs.xml
index 8690ac6..30a9412 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -8,6 +8,7 @@
<rule ref="Generic.ControlStructures" />
<rule ref="Generic.Files.ByteOrderMark" />
+ <rule ref="Generic.Files.EndFileNewline" />
<rule ref="Generic.Files.InlineHTML" />
<rule ref="Generic.Files.LineEndings" />
<rule ref="Generic.Files.OneInterfacePerFile" />
diff --git a/purtle/init.mw.php b/purtle/init.mw.php
index 370f6ed..7a63110 100644
--- a/purtle/init.mw.php
+++ b/purtle/init.mw.php
@@ -20,4 +20,4 @@
$GLOBALS['wgHooks']['UnitTestsList'][] = function( array &$paths ) {
$paths[] = __DIR__ . '/tests/phpunit';
-};
\ No newline at end of file
+};
diff --git a/repo/ExampleSettings.php b/repo/ExampleSettings.php
index af1e3c7..6310835 100644
--- a/repo/ExampleSettings.php
+++ b/repo/ExampleSettings.php
@@ -2,4 +2,4 @@
define( 'WB_REPO_EXAMPLE_ENTRY', 1 );
-include_once( __DIR__ . '/config/Wikibase.example.php' );
\ No newline at end of file
+include_once( __DIR__ . '/config/Wikibase.example.php' );
diff --git a/repo/includes/ChangeOp/ChangeOpQualifierRemove.php
b/repo/includes/ChangeOp/ChangeOpQualifierRemove.php
index 5d3535c..e2204b7 100644
--- a/repo/includes/ChangeOp/ChangeOpQualifierRemove.php
+++ b/repo/includes/ChangeOp/ChangeOpQualifierRemove.php
@@ -122,4 +122,4 @@
return parent::validate( $entity );
}
-}
\ No newline at end of file
+}
diff --git a/repo/includes/DataTypeSelector.php
b/repo/includes/DataTypeSelector.php
index 65ab712..cb54763 100644
--- a/repo/includes/DataTypeSelector.php
+++ b/repo/includes/DataTypeSelector.php
@@ -110,4 +110,4 @@
return $html;
}
-}
\ No newline at end of file
+}
diff --git a/repo/includes/Hooks/EditFilterHookRunner.php
b/repo/includes/Hooks/EditFilterHookRunner.php
index 7aeee89..cfd2cbb 100644
--- a/repo/includes/Hooks/EditFilterHookRunner.php
+++ b/repo/includes/Hooks/EditFilterHookRunner.php
@@ -141,4 +141,4 @@
return $context;
}
-}
\ No newline at end of file
+}
diff --git a/repo/includes/LinkedData/HttpAcceptNegotiator.php
b/repo/includes/LinkedData/HttpAcceptNegotiator.php
index 7e96f93..bfaa933 100644
--- a/repo/includes/LinkedData/HttpAcceptNegotiator.php
+++ b/repo/includes/LinkedData/HttpAcceptNegotiator.php
@@ -135,4 +135,5 @@
return false;
}
-}
\ No newline at end of file
+
+}
diff --git a/repo/includes/LinkedData/HttpAcceptParser.php
b/repo/includes/LinkedData/HttpAcceptParser.php
index ae66484..97364bf 100644
--- a/repo/includes/LinkedData/HttpAcceptParser.php
+++ b/repo/includes/LinkedData/HttpAcceptParser.php
@@ -75,4 +75,4 @@
return $weights;
}
-}
\ No newline at end of file
+}
diff --git a/repo/includes/Notifications/DatabaseChangeTransmitter.php
b/repo/includes/Notifications/DatabaseChangeTransmitter.php
index 97c4306..522a8d9 100644
--- a/repo/includes/Notifications/DatabaseChangeTransmitter.php
+++ b/repo/includes/Notifications/DatabaseChangeTransmitter.php
@@ -40,4 +40,4 @@
}
}
-}
\ No newline at end of file
+}
diff --git a/repo/includes/Notifications/HookChangeTransmitter.php
b/repo/includes/Notifications/HookChangeTransmitter.php
index 1388ecc..b611fdf 100644
--- a/repo/includes/Notifications/HookChangeTransmitter.php
+++ b/repo/includes/Notifications/HookChangeTransmitter.php
@@ -40,4 +40,4 @@
Hooks::run( $this->hookName, array( $change ) );
}
-}
\ No newline at end of file
+}
diff --git a/repo/includes/Validators/EntityValidator.php
b/repo/includes/Validators/EntityValidator.php
index 9d7e05e..fe43f23 100644
--- a/repo/includes/Validators/EntityValidator.php
+++ b/repo/includes/Validators/EntityValidator.php
@@ -31,4 +31,4 @@
*/
public function validateEntity( EntityDocument $entity );
-}
\ No newline at end of file
+}
diff --git a/repo/includes/actions/HistoryItemAction.php
b/repo/includes/actions/HistoryItemAction.php
index de87836..de2d15d 100644
--- a/repo/includes/actions/HistoryItemAction.php
+++ b/repo/includes/actions/HistoryItemAction.php
@@ -12,4 +12,4 @@
*/
class HistoryItemAction extends HistoryEntityAction {
-}
\ No newline at end of file
+}
diff --git a/repo/includes/actions/HistoryPropertyAction.php
b/repo/includes/actions/HistoryPropertyAction.php
index b8d78c5..9560e0c 100644
--- a/repo/includes/actions/HistoryPropertyAction.php
+++ b/repo/includes/actions/HistoryPropertyAction.php
@@ -12,4 +12,4 @@
*/
class HistoryPropertyAction extends HistoryEntityAction {
-}
\ No newline at end of file
+}
diff --git a/repo/includes/actions/SubmitItemAction.php
b/repo/includes/actions/SubmitItemAction.php
index 7394b47..349fd64 100644
--- a/repo/includes/actions/SubmitItemAction.php
+++ b/repo/includes/actions/SubmitItemAction.php
@@ -12,4 +12,4 @@
*/
class SubmitItemAction extends SubmitEntityAction {
-}
\ No newline at end of file
+}
diff --git a/repo/includes/actions/SubmitPropertyAction.php
b/repo/includes/actions/SubmitPropertyAction.php
index a43aef2..9d67df8 100644
--- a/repo/includes/actions/SubmitPropertyAction.php
+++ b/repo/includes/actions/SubmitPropertyAction.php
@@ -12,5 +12,4 @@
*/
class SubmitPropertyAction extends SubmitEntityAction {
-
-}
\ No newline at end of file
+}
diff --git a/repo/includes/actions/ViewItemAction.php
b/repo/includes/actions/ViewItemAction.php
index 4348bfa..3c141ff 100644
--- a/repo/includes/actions/ViewItemAction.php
+++ b/repo/includes/actions/ViewItemAction.php
@@ -13,4 +13,4 @@
*/
class ViewItemAction extends ViewEntityAction {
-}
\ No newline at end of file
+}
diff --git a/repo/includes/actions/ViewPropertyAction.php
b/repo/includes/actions/ViewPropertyAction.php
index 55a7371..fab1e91 100644
--- a/repo/includes/actions/ViewPropertyAction.php
+++ b/repo/includes/actions/ViewPropertyAction.php
@@ -12,4 +12,4 @@
*/
class ViewPropertyAction extends ViewEntityAction {
-}
\ No newline at end of file
+}
diff --git a/repo/includes/api/ApiHelperFactory.php
b/repo/includes/api/ApiHelperFactory.php
index 3db43d7..d9bf807 100644
--- a/repo/includes/api/ApiHelperFactory.php
+++ b/repo/includes/api/ApiHelperFactory.php
@@ -103,4 +103,3 @@
}
}
-
\ No newline at end of file
diff --git a/repo/tests/phpunit/includes/ChangeOp/ChangeOpSiteLinkTest.php
b/repo/tests/phpunit/includes/ChangeOp/ChangeOpSiteLinkTest.php
index bf46ced..287ab0e 100644
--- a/repo/tests/phpunit/includes/ChangeOp/ChangeOpSiteLinkTest.php
+++ b/repo/tests/phpunit/includes/ChangeOp/ChangeOpSiteLinkTest.php
@@ -275,4 +275,5 @@
$summary->getAutoSummaryArgs()
);
}
-}
\ No newline at end of file
+
+}
diff --git a/repo/tests/phpunit/includes/Hooks/EditFilterHookRunnerTest.php
b/repo/tests/phpunit/includes/Hooks/EditFilterHookRunnerTest.php
index 4139b6e..6f10918 100644
--- a/repo/tests/phpunit/includes/Hooks/EditFilterHookRunnerTest.php
+++ b/repo/tests/phpunit/includes/Hooks/EditFilterHookRunnerTest.php
@@ -192,4 +192,4 @@
$this->assertEquals( $expected['status'], $status );
}
-}
\ No newline at end of file
+}
diff --git a/repo/tests/phpunit/includes/api/PermissionsTestCase.php
b/repo/tests/phpunit/includes/api/PermissionsTestCase.php
index 99ba3ce..7586fc5 100644
--- a/repo/tests/phpunit/includes/api/PermissionsTestCase.php
+++ b/repo/tests/phpunit/includes/api/PermissionsTestCase.php
@@ -70,4 +70,4 @@
}
}
-}
\ No newline at end of file
+}
--
To view, visit https://gerrit.wikimedia.org/r/222262
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iee3fbf2844fa00af4eb40a25349459f573c24684
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
