[MediaWiki-commits] [Gerrit] Reposition snak type selector after resize - change (mediawiki...Wikibase)

[Jonas Kress (WMDE) (Code Review)]

Jonas Kress (WMDE) has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/223818

Change subject: Reposition snak type selector after resize
......................................................................

Reposition snak type selector after resize

Calling repositionMenu() after a window resize event
Bug: T97288

Change-Id: Ia9f4aa93ea06aaedb24fbcc56e159df47ef13617
---
M view/resources/jquery/wikibase/jquery.wikibase.badgeselector.js
M view/resources/jquery/wikibase/jquery.wikibase.statementview.RankSelector.js
M view/resources/jquery/wikibase/snakview/snakview.SnakTypeSelector.js
3 files changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/18/223818/1

diff --git a/view/resources/jquery/wikibase/jquery.wikibase.badgeselector.js 
b/view/resources/jquery/wikibase/jquery.wikibase.badgeselector.js
index f2bc1bd..ab1ffa1 100644
--- a/view/resources/jquery/wikibase/jquery.wikibase.badgeselector.js
+++ b/view/resources/jquery/wikibase/jquery.wikibase.badgeselector.js
@@ -150,7 +150,7 @@
                };
 
                $( document ).on( 'mouseup.' + this.widgetName, degrade );
-               $( window ).on( 'resize.' + this.widgetName, degrade );
+               $( window ).on( 'resize.' + this.widgetName, function( event ) 
{ self.repositionMenu(); } );
 
                $menu.on( 'click.' + this.widgetName, function( event ) {
                        var $li = $( event.target ).closest( 'li' ),
diff --git 
a/view/resources/jquery/wikibase/jquery.wikibase.statementview.RankSelector.js 
b/view/resources/jquery/wikibase/jquery.wikibase.statementview.RankSelector.js
index 1f40751..90fd8ab 100644
--- 
a/view/resources/jquery/wikibase/jquery.wikibase.statementview.RankSelector.js
+++ 
b/view/resources/jquery/wikibase/jquery.wikibase.statementview.RankSelector.js
@@ -120,7 +120,7 @@
                                };
 
                                $( document ).on( 'mouseup.' + self.widgetName, 
degrade  );
-                               $( window ).on( 'resize.' + self.widgetName, 
degrade );
+                               $( window ).on( 'resize.' + self.widgetName, 
function( event ) { self.repositionMenu(); } );
                        } );
 
                        this._setRank( this.options.value );
diff --git 
a/view/resources/jquery/wikibase/snakview/snakview.SnakTypeSelector.js 
b/view/resources/jquery/wikibase/snakview/snakview.SnakTypeSelector.js
index 1330004..76e400f 100644
--- a/view/resources/jquery/wikibase/snakview/snakview.SnakTypeSelector.js
+++ b/view/resources/jquery/wikibase/snakview/snakview.SnakTypeSelector.js
@@ -95,7 +95,7 @@
                                        self._unbindGlobalListenersFn = $.noop;
                                };
                                $( document ).on( 'mouseup.' + widgetName, 
degrade  );
-                               $( window ).on( 'resize.' + widgetName, degrade 
);
+                               $( window ).on( 'resize.' + widgetName, 
function( event ) { self.repositionMenu(); }  );
                        } );
 
                        this._$icon = $( '<span/>' )

-- 
To view, visit https://gerrit.wikimedia.org/r/223818
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia9f4aa93ea06aaedb24fbcc56e159df47ef13617
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jonas Kress (WMDE) <jonas.kr...@wikimedia.de>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits