jenkins-bot has submitted this change and it was merged. Change subject: Reposition snak type selector after resize ......................................................................
Reposition snak type selector after resize Calling repositionMenu() after a window resize event. Bug: T97288 Change-Id: Ia9f4aa93ea06aaedb24fbcc56e159df47ef13617 --- M view/resources/jquery/wikibase/jquery.wikibase.badgeselector.js M view/resources/jquery/wikibase/jquery.wikibase.statementview.RankSelector.js M view/resources/jquery/wikibase/snakview/snakview.SnakTypeSelector.js 3 files changed, 7 insertions(+), 6 deletions(-) Approvals: Thiemo Mättig (WMDE): Looks good to me, approved jenkins-bot: Verified diff --git a/view/resources/jquery/wikibase/jquery.wikibase.badgeselector.js b/view/resources/jquery/wikibase/jquery.wikibase.badgeselector.js index f2bc1bd..ab1ffa1 100644 --- a/view/resources/jquery/wikibase/jquery.wikibase.badgeselector.js +++ b/view/resources/jquery/wikibase/jquery.wikibase.badgeselector.js @@ -150,7 +150,7 @@ }; $( document ).on( 'mouseup.' + this.widgetName, degrade ); - $( window ).on( 'resize.' + this.widgetName, degrade ); + $( window ).on( 'resize.' + this.widgetName, function( event ) { self.repositionMenu(); } ); $menu.on( 'click.' + this.widgetName, function( event ) { var $li = $( event.target ).closest( 'li' ), diff --git a/view/resources/jquery/wikibase/jquery.wikibase.statementview.RankSelector.js b/view/resources/jquery/wikibase/jquery.wikibase.statementview.RankSelector.js index 1f40751..90fd8ab 100644 --- a/view/resources/jquery/wikibase/jquery.wikibase.statementview.RankSelector.js +++ b/view/resources/jquery/wikibase/jquery.wikibase.statementview.RankSelector.js @@ -120,7 +120,7 @@ }; $( document ).on( 'mouseup.' + self.widgetName, degrade ); - $( window ).on( 'resize.' + self.widgetName, degrade ); + $( window ).on( 'resize.' + self.widgetName, function( event ) { self.repositionMenu(); } ); } ); this._setRank( this.options.value ); diff --git a/view/resources/jquery/wikibase/snakview/snakview.SnakTypeSelector.js b/view/resources/jquery/wikibase/snakview/snakview.SnakTypeSelector.js index 1330004..070b81d 100644 --- a/view/resources/jquery/wikibase/snakview/snakview.SnakTypeSelector.js +++ b/view/resources/jquery/wikibase/snakview/snakview.SnakTypeSelector.js @@ -86,16 +86,17 @@ } self._unbindGlobalListenersFn(); }; + var repositionMenu = function( event ) { self.repositionMenu(); }; // also make this available for destroy() function! self._unbindGlobalListenersFn = function() { // unbind event after closing menu, explicitly unbind specific handler to // support instantiation of multiple snaktypeselector widgets. - $( document ).add( $( window ) ) - .off( 'mouseup.' + widgetName + 'resize.' + widgetName, degrade ); + $( document ).off( 'mouseup.' + widgetName, degrade ); + $( window ).off( 'resize.' + widgetName, repositionMenu ); self._unbindGlobalListenersFn = $.noop; }; - $( document ).on( 'mouseup.' + widgetName, degrade ); - $( window ).on( 'resize.' + widgetName, degrade ); + $( document ).on( 'mouseup.' + widgetName, degrade ); + $( window ).on( 'resize.' + widgetName, repositionMenu ); } ); this._$icon = $( '<span/>' ) -- To view, visit https://gerrit.wikimedia.org/r/223818 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia9f4aa93ea06aaedb24fbcc56e159df47ef13617 Gerrit-PatchSet: 7 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jonas Kress (WMDE) <jonas.kr...@wikimedia.de> Gerrit-Reviewer: Addshore <addshorew...@gmail.com> Gerrit-Reviewer: Bene <benestar.wikime...@gmail.com> Gerrit-Reviewer: Hoo man <h...@online.de> Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de> Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits