Ori.livneh has submitted this change and it was merged. Change subject: Re-think error-handling and revisions in JS module ......................................................................
Re-think error-handling and revisions in JS module - Rename SchemaModule->schema to SchemaModule->title - Rename SchemaModule->rev to SchemaModule->revision (consistency) - If no revision specified, set SchemaModule->revision to 'HEAD' - Separate module retrieval from JS code generation - Alias mw.eventLog as 'self' in JS module closure - setSchemas -> setSchema; accepts a 'meta' object containing schema + information. - Change throw new Error()s to self.warn. - Capture all logged events in metadata object Change-Id: Ie17d92f449a722a9963fc6d2124e86c82576130f --- M EventLogging.module.php M modules/ext.eventLogging.core.js M tests/ext.eventLogging.tests.js 3 files changed, 126 insertions(+), 91 deletions(-) Approvals: Ori.livneh: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/36690 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie17d92f449a722a9963fc6d2124e86c82576130f Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/extensions/EventLogging Gerrit-Branch: master Gerrit-Owner: Ori.livneh <[email protected]> Gerrit-Reviewer: Ori.livneh <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
