Jdlrobson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/229023

Change subject: Fix search in pages feature in firefox
......................................................................

Fix search in pages feature in firefox

See https://phabricator.wikimedia.org/P1822 for a minimum test case.
Firefox 39 will not submit it whereas Chrome 44 will.

Bug:
Change-Id: Ic63498a2c9b2a5262181dcde98819b198b2dd039
---
M resources/mobile.search/SearchOverlay.js
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/23/229023/1

diff --git a/resources/mobile.search/SearchOverlay.js 
b/resources/mobile.search/SearchOverlay.js
index 728e437..7a6931a 100644
--- a/resources/mobile.search/SearchOverlay.js
+++ b/resources/mobile.search/SearchOverlay.js
@@ -166,6 +166,8 @@
                        // history.back queues a task so might run after this 
call. Thus we use setTimeout
                        // 
http://www.w3.org/TR/2011/WD-html5-20110113/webappapis.html#queue-a-task
                        window.setTimeout( function () {
+                               // Firefox doesn't allow submission of a form 
not in the DOM so temporarily re-add it
+                               $form.appendTo( document.body );
                                $form.submit();
                        }, 0 );
                },

-- 
To view, visit https://gerrit.wikimedia.org/r/229023
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic63498a2c9b2a5262181dcde98819b198b2dd039
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to