jenkins-bot has submitted this change and it was merged. Change subject: Fix search in pages feature in firefox ......................................................................
Fix search in pages feature in firefox See https://phabricator.wikimedia.org/P1822 for a minimum test case. Firefox 39 will not submit it whereas Chrome 44 will. Bug: T98476 Change-Id: Ic63498a2c9b2a5262181dcde98819b198b2dd039 --- M resources/mobile.search/SearchOverlay.js 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Robmoen: Looks good to me, approved Bmansurov: Looks good to me, but someone else must approve jenkins-bot: Verified diff --git a/resources/mobile.search/SearchOverlay.js b/resources/mobile.search/SearchOverlay.js index 728e437..7a6931a 100644 --- a/resources/mobile.search/SearchOverlay.js +++ b/resources/mobile.search/SearchOverlay.js @@ -166,6 +166,8 @@ // history.back queues a task so might run after this call. Thus we use setTimeout // http://www.w3.org/TR/2011/WD-html5-20110113/webappapis.html#queue-a-task window.setTimeout( function () { + // Firefox doesn't allow submission of a form not in the DOM so temporarily re-add it + $form.appendTo( document.body ); $form.submit(); }, 0 ); }, -- To view, visit https://gerrit.wikimedia.org/r/229023 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic63498a2c9b2a5262181dcde98819b198b2dd039 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Jdlrobson <[email protected]> Gerrit-Reviewer: Bmansurov <[email protected]> Gerrit-Reviewer: Jdlrobson <[email protected]> Gerrit-Reviewer: Robmoen <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
