Bartosz Dziewoński has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231471

Change subject: CapsuleMultiSelectWidget: Unbreak $overlay config option
......................................................................

CapsuleMultiSelectWidget: Unbreak $overlay config option

It did not work as expected, the menu was not positioned
next to the widget if it was used.

Change-Id: Ib389494ba5e9ef08aab02f07631f5a3fd9659df3
---
M src/widgets/CapsuleMultiSelectWidget.js
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/71/231471/1

diff --git a/src/widgets/CapsuleMultiSelectWidget.js 
b/src/widgets/CapsuleMultiSelectWidget.js
index 23a78ba..fd735af 100644
--- a/src/widgets/CapsuleMultiSelectWidget.js
+++ b/src/widgets/CapsuleMultiSelectWidget.js
@@ -91,10 +91,11 @@
        // Properties
        this.allowArbitrary = !!config.allowArbitrary;
        this.$overlay = config.$overlay || this.$element;
-       this.menu = new OO.ui.MenuSelectWidget( $.extend(
+       this.menu = new OO.ui.FloatingMenuSelectWidget( $.extend(
                {
                        widget: this,
                        $input: this.$input,
+                       $container: this.$element,
                        filterFromInput: true,
                        disabled: this.isDisabled()
                },

-- 
To view, visit https://gerrit.wikimedia.org/r/231471
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib389494ba5e9ef08aab02f07631f5a3fd9659df3
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to