jenkins-bot has submitted this change and it was merged.
Change subject: CapsuleMultiSelectWidget: Unbreak $overlay config option
......................................................................
CapsuleMultiSelectWidget: Unbreak $overlay config option
It did not work as expected, the menu was not positioned
next to the widget if it was used.
Change-Id: Ib389494ba5e9ef08aab02f07631f5a3fd9659df3
---
M src/widgets/CapsuleMultiSelectWidget.js
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/widgets/CapsuleMultiSelectWidget.js
b/src/widgets/CapsuleMultiSelectWidget.js
index 23a78ba..fd735af 100644
--- a/src/widgets/CapsuleMultiSelectWidget.js
+++ b/src/widgets/CapsuleMultiSelectWidget.js
@@ -91,10 +91,11 @@
// Properties
this.allowArbitrary = !!config.allowArbitrary;
this.$overlay = config.$overlay || this.$element;
- this.menu = new OO.ui.MenuSelectWidget( $.extend(
+ this.menu = new OO.ui.FloatingMenuSelectWidget( $.extend(
{
widget: this,
$input: this.$input,
+ $container: this.$element,
filterFromInput: true,
disabled: this.isDisabled()
},
--
To view, visit https://gerrit.wikimedia.org/r/231471
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib389494ba5e9ef08aab02f07631f5a3fd9659df3
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Anomie <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
