Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/231732
Change subject: Take into account height in positioning.
......................................................................
Take into account height in positioning.
Given a banner is 960 × 717 pixels this positioning is equally useful
for optimising the image for tablet display.
Change-Id: I2c2958e1d3de0d3ff4e9587715dd921580793f0b
---
M
resources/ext.WikidataPageBanner.positionBanner/ext.WikidataPageBanner.positionBanner.js
1 file changed, 2 insertions(+), 1 deletion(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikidataPageBanner
refs/changes/32/231732/1
diff --git
a/resources/ext.WikidataPageBanner.positionBanner/ext.WikidataPageBanner.positionBanner.js
b/resources/ext.WikidataPageBanner.positionBanner/ext.WikidataPageBanner.positionBanner.js
index 3b76f79..9b38399 100644
---
a/resources/ext.WikidataPageBanner.positionBanner/ext.WikidataPageBanner.positionBanner.js
+++
b/resources/ext.WikidataPageBanner.positionBanner/ext.WikidataPageBanner.positionBanner.js
@@ -38,7 +38,8 @@
totalOffsetY = minOffsetTop;
}
}
- if ( $wpbBannerImage.width() > $wpbBannerImageContainer.width() ) {
+ if ( $wpbBannerImage.width() > $wpbBannerImageContainer.width() ||
+ $wpbBannerImage.height() > $wpbBannerImageContainer.height() ) {
// this is the max shift that can be achieved without leaving
blank space
maxOffsetLeft = $wpbBannerImage.width() -
$wpbBannerImageContainer.width();
--
To view, visit https://gerrit.wikimedia.org/r/231732
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2c2958e1d3de0d3ff4e9587715dd921580793f0b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikidataPageBanner
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
