Asadsalman has uploaded a new change for review.
https://gerrit.wikimedia.org/r/231730
Change subject: Fixed Save All/Clear All Actions MenuItem that would be visible
even if nothing is in savedPageList
......................................................................
Fixed Save All/Clear All Actions MenuItem that would be visible even if
nothing is in savedPageList
Added if-condition in onPrepareOptionsMenu() method and setVisible(false)
for the MenuItem if nothing is in savedPageList
Bug: T10528
Change-Id: I169d6e3638ea47a418eeedccc774b5059974f7cd
---
M app/src/main/java/org/wikipedia/savedpages/SavedPagesFragment.java
1 file changed, 8 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/30/231730/1
diff --git a/app/src/main/java/org/wikipedia/savedpages/SavedPagesFragment.java
b/app/src/main/java/org/wikipedia/savedpages/SavedPagesFragment.java
index d9c98c8..cabf648 100644
--- a/app/src/main/java/org/wikipedia/savedpages/SavedPagesFragment.java
+++ b/app/src/main/java/org/wikipedia/savedpages/SavedPagesFragment.java
@@ -316,8 +316,14 @@
if (!isAdded() || ((PageActivity)getActivity()).isSearching()) {
return;
}
-
menu.findItem(R.id.menu_clear_all_saved_pages).setEnabled(savedPagesList.getCount()
> 0);
-
menu.findItem(R.id.menu_refresh_all_saved_pages).setEnabled(savedPagesList.getCount()
> 0);
+ MenuItem clear_all_action
=(MenuItem)menu.findItem(R.id.menu_clear_all_saved_pages).setEnabled(savedPagesList.getCount()
> 0);
+ MenuItem refresh_all_action
=(MenuItem)menu.findItem(R.id.menu_refresh_all_saved_pages).setEnabled(savedPagesList.getCount()
> 0);
+
+
+ if(!(savedPagesList.getCount() > 0)){
+ clear_all_action.setVisible(false);
+ refresh_all_action.setVisible(false);
+ }
}
@Override
--
To view, visit https://gerrit.wikimedia.org/r/231730
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I169d6e3638ea47a418eeedccc774b5059974f7cd
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Asadsalman <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
