[MediaWiki-commits] [Gerrit] Share only the page URL from the overflow menu. - change (apps...wikipedia)

[Dbrant (Code Review)]

Dbrant has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/232039

Change subject: Share only the page URL from the overflow menu.
......................................................................

Share only the page URL from the overflow menu.

Bug: T108181
Change-Id: I371bff4bf5c2b3aeec6dfff708b4de5cba3306cf
---
M app/src/main/java/org/wikipedia/page/PageFragment.java
M app/src/main/java/org/wikipedia/page/snippet/ShareHandler.java
2 files changed, 3 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/39/232039/1

diff --git a/app/src/main/java/org/wikipedia/page/PageFragment.java 
b/app/src/main/java/org/wikipedia/page/PageFragment.java
index 865ad8c..4763695 100755
--- a/app/src/main/java/org/wikipedia/page/PageFragment.java
+++ b/app/src/main/java/org/wikipedia/page/PageFragment.java
@@ -128,6 +128,7 @@
     private ReferenceDialog referenceDialog;
     private EditHandler editHandler;
     private ActionMode findInPageActionMode;
+    PageLongPressHandler.WebViewContextMenuListener contextMenuListener;
 
     private WikipediaApp app;
 
@@ -340,7 +341,7 @@
         tabsProvider = new TabsProvider(getPageActivity(), tabList);
         tabsProvider.setTabsProviderListener(tabsProviderListener);
 
-        PageLongPressHandler.WebViewContextMenuListener contextMenuListener = 
new LongPressHandler(getPageActivity());
+        contextMenuListener = new LongPressHandler(getPageActivity());
         new PageLongPressHandler(getActivity(), webView, 
HistoryEntry.SOURCE_INTERNAL_LINK,
                 contextMenuListener);
 
@@ -732,7 +733,7 @@
                 }
                 return true;
             case R.id.menu_page_share:
-                shareHandler.shareWithoutSelection();
+                contextMenuListener.onShareLink(model.getTitle());
                 return true;
             case R.id.menu_page_other_languages:
                 Intent langIntent = new Intent();
diff --git a/app/src/main/java/org/wikipedia/page/snippet/ShareHandler.java 
b/app/src/main/java/org/wikipedia/page/snippet/ShareHandler.java
index 3cd761a..721b456 100755
--- a/app/src/main/java/org/wikipedia/page/snippet/ShareHandler.java
+++ b/app/src/main/java/org/wikipedia/page/snippet/ShareHandler.java
@@ -97,10 +97,6 @@
         }
     }
 
-    public void shareWithoutSelection() {
-        requestTextSelection();
-    }
-
     public void onDestroy() {
         if (shareDialog != null) {
             shareDialog.dismiss();

-- 
To view, visit https://gerrit.wikimedia.org/r/232039
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I371bff4bf5c2b3aeec6dfff708b4de5cba3306cf
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <dbr...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits