jenkins-bot has submitted this change and it was merged.
Change subject: Share only the page URL from the overflow menu.
......................................................................
Share only the page URL from the overflow menu.
Prior to this patch, the behavior when selecting the Share option from the
overflow menu was to launch the Share-a-fact dialog with the first
paragraph of text. But in fact, all that users really want is to share the
URL of the page. At the time of this writing, this is one of the most
requested features to be brought back.
Bug: T108181
Change-Id: I371bff4bf5c2b3aeec6dfff708b4de5cba3306cf
---
M app/src/main/java/org/wikipedia/page/PageActivityLongPressHandler.java
M app/src/main/java/org/wikipedia/page/PageFragment.java
M app/src/main/java/org/wikipedia/page/snippet/ShareHandler.java
M app/src/main/java/org/wikipedia/util/ShareUtils.java
4 files changed, 8 insertions(+), 10 deletions(-)
Approvals:
Sniedzielski: Looks good to me, approved
Mholloway: Looks good to me, but someone else must approve
Niedzielski: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git
a/app/src/main/java/org/wikipedia/page/PageActivityLongPressHandler.java
b/app/src/main/java/org/wikipedia/page/PageActivityLongPressHandler.java
index 9bbfc64..62c2066 100644
--- a/app/src/main/java/org/wikipedia/page/PageActivityLongPressHandler.java
+++ b/app/src/main/java/org/wikipedia/page/PageActivityLongPressHandler.java
@@ -37,16 +37,12 @@
@Override
public void onShareLink(PageTitle title) {
- shareLink(title.getDisplayText(), title.getCanonicalUri());
+ ShareUtils.shareText(activity, title);
}
@Override
public void onSavePage(PageTitle title) {
spawnSavePageTask(title);
- }
-
- private void shareLink(String title, String url) {
- ShareUtils.shareText(activity, title, url);
}
private void copyLink(String url) {
diff --git a/app/src/main/java/org/wikipedia/page/PageFragment.java
b/app/src/main/java/org/wikipedia/page/PageFragment.java
index 865ad8c..bf4341b 100755
--- a/app/src/main/java/org/wikipedia/page/PageFragment.java
+++ b/app/src/main/java/org/wikipedia/page/PageFragment.java
@@ -28,6 +28,7 @@
import org.wikipedia.settings.Prefs;
import org.wikipedia.tooltip.ToolTipUtil;
import org.wikipedia.util.FeedbackUtil;
+import org.wikipedia.util.ShareUtils;
import org.wikipedia.util.ThrowableUtil;
import org.wikipedia.views.ObservableWebView;
import org.wikipedia.views.SwipeRefreshLayoutWithScroll;
@@ -732,7 +733,7 @@
}
return true;
case R.id.menu_page_share:
- shareHandler.shareWithoutSelection();
+ ShareUtils.shareText(getActivity(), model.getTitle());
return true;
case R.id.menu_page_other_languages:
Intent langIntent = new Intent();
diff --git a/app/src/main/java/org/wikipedia/page/snippet/ShareHandler.java
b/app/src/main/java/org/wikipedia/page/snippet/ShareHandler.java
index 3cd761a..721b456 100755
--- a/app/src/main/java/org/wikipedia/page/snippet/ShareHandler.java
+++ b/app/src/main/java/org/wikipedia/page/snippet/ShareHandler.java
@@ -97,10 +97,6 @@
}
}
- public void shareWithoutSelection() {
- requestTextSelection();
- }
-
public void onDestroy() {
if (shareDialog != null) {
shareDialog.dismiss();
diff --git a/app/src/main/java/org/wikipedia/util/ShareUtils.java
b/app/src/main/java/org/wikipedia/util/ShareUtils.java
index 56a5781..b4262e7 100644
--- a/app/src/main/java/org/wikipedia/util/ShareUtils.java
+++ b/app/src/main/java/org/wikipedia/util/ShareUtils.java
@@ -15,6 +15,7 @@
import org.wikipedia.R;
import org.wikipedia.concurrency.SaneAsyncTask;
+import org.wikipedia.page.PageTitle;
import java.io.ByteArrayOutputStream;
import java.io.File;
@@ -48,6 +49,10 @@
}
}
+ public static void shareText(final Context context, final PageTitle title)
{
+ shareText(context, title.getDisplayText(), title.getCanonicalUri());
+ }
+
/**
* Share a bitmap image using an activity chooser, so that the user can
choose the
* app with which to share the content.
--
To view, visit https://gerrit.wikimedia.org/r/232039
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I371bff4bf5c2b3aeec6dfff708b4de5cba3306cf
Gerrit-PatchSet: 3
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <[email protected]>
Gerrit-Reviewer: BearND <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Mholloway <[email protected]>
Gerrit-Reviewer: Niedzielski <[email protected]>
Gerrit-Reviewer: Sniedzielski <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
