Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/232073
Change subject: Add close button to debug bar
......................................................................
Add close button to debug bar
Change-Id: I0a3bdae29f632d04353abc184093ebb025eaeb12
---
M src/ui/ve.ui.DebugBar.js
1 file changed, 10 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor
refs/changes/73/232073/1
diff --git a/src/ui/ve.ui.DebugBar.js b/src/ui/ve.ui.DebugBar.js
index 84d230e..ac77c18 100644
--- a/src/ui/ve.ui.DebugBar.js
+++ b/src/ui/ve.ui.DebugBar.js
@@ -18,7 +18,7 @@
// Parent constructor
OO.ui.Element.call( this, config );
- var dumpModelButtonGroup, hideDumpButton;
+ var dumpModelButtonGroup, hideDumpButton, closeButton;
this.surface = surface;
@@ -31,6 +31,11 @@
hideDumpButton = new OO.ui.ButtonWidget( {
icon: 'collapse',
label: 'Hide'
+ } );
+
+ closeButton = new OO.ui.ButtonWidget( {
+ icon: 'close',
+ label: 'Close'
} );
this.$dump =
@@ -69,6 +74,7 @@
this.inputDebuggingToggle.on( 'click',
this.onInputDebuggingToggleClick.bind( this ) );
this.filibusterToggle.on( 'click', this.onFilibusterToggleClick.bind(
this ) );
hideDumpButton.on( 'click', this.$dump.hide.bind( this.$dump ) );
+ closeButton.on( 'click', this.$element.remove.bind( this.$element ) );
this.onDumpModelChangeToggleClick();
this.getSurface().getModel().connect( this, { select: 'onSurfaceSelect'
} );
@@ -82,7 +88,9 @@
$( this.constructor.static.dividerTemplate ),
dumpModelButtonGroup.$element,
this.inputDebuggingToggle.$element,
- this.filibusterToggle.$element
+ this.filibusterToggle.$element,
+ $( this.constructor.static.dividerTemplate ),
+ closeButton.$element
),
this.$dump,
this.$filibuster
--
To view, visit https://gerrit.wikimedia.org/r/232073
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0a3bdae29f632d04353abc184093ebb025eaeb12
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
