Sumit has uploaded a new change for review.
https://gerrit.wikimedia.org/r/232072
Change subject: WikidataPageBanner add .jshintrc
......................................................................
WikidataPageBanner add .jshintrc
Add .jshintrc
Edit Gruntfile.js to test resources/ and tests/qunit/
Fix jshint errors.
Change-Id: I518cab59234b4f50a34aa58baba6938da020e2c3
---
A .jshintrc
M Gruntfile.js
M
resources/ext.WikidataPageBanner.positionBanner/ext.WikidataPageBanner.positionBanner.js
3 files changed, 24 insertions(+), 2 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikidataPageBanner
refs/changes/72/232072/1
diff --git a/.jshintrc b/.jshintrc
new file mode 100644
index 0000000..df30cb2
--- /dev/null
+++ b/.jshintrc
@@ -0,0 +1,21 @@
+{
+ "globals": {
+ "console": true,
+ "jQuery": true,
+ "JsDiff": true,
+ "Hogan": true,
+ "QUnit": true,
+ "mw": true,
+ "OO": true
+ },
+
+ "browser": true,
+ "curly": true,
+ "eqeqeq": true,
+ "forin": false,
+ "onevar": true,
+ "trailing": true,
+ "undef" : true,
+ "unused": true,
+ "supernew": true
+}
diff --git a/Gruntfile.js b/Gruntfile.js
index 0f6ab82..5cac144 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -10,7 +10,8 @@
jshintrc: true
},
all: [
- '*.js'
+ 'resources/**/*.js',
+ 'tests/qunit/**/*.js'
]
},
banana: {
diff --git
a/resources/ext.WikidataPageBanner.positionBanner/ext.WikidataPageBanner.positionBanner.js
b/resources/ext.WikidataPageBanner.positionBanner/ext.WikidataPageBanner.positionBanner.js
index a685f09..d5b8692 100644
---
a/resources/ext.WikidataPageBanner.positionBanner/ext.WikidataPageBanner.positionBanner.js
+++
b/resources/ext.WikidataPageBanner.positionBanner/ext.WikidataPageBanner.positionBanner.js
@@ -63,7 +63,7 @@
$( window ).on( 'resize', $.debounce(
100,
function() {
- positionBanner( $wpbBannerImageContainer )
+ positionBanner( $wpbBannerImageContainer );
}
) );
positionBanner( $wpbBannerImageContainer );
--
To view, visit https://gerrit.wikimedia.org/r/232072
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I518cab59234b4f50a34aa58baba6938da020e2c3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikidataPageBanner
Gerrit-Branch: master
Gerrit-Owner: Sumit <asthana.sumi...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
