Jforrester has uploaded a new change for review.
https://gerrit.wikimedia.org/r/232554
Change subject: build: Enable jscs jsDoc rule 'checkTypes' and make pass
......................................................................
build: Enable jscs jsDoc rule 'checkTypes' and make pass
Change-Id: Idbf6e698ba7015ee5e4f1cf78234ad3f187f1c06
---
M .jscsrc
M modules/ve-mw/dm/nodes/ve.dm.MWReferenceNode.js
M modules/ve-mw/ui/tools/ve.ui.MWPopupTool.js
3 files changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/54/232554/1
diff --git a/.jscsrc b/.jscsrc
index 43fbbeb..1bb59d4 100644
--- a/.jscsrc
+++ b/.jscsrc
@@ -10,6 +10,7 @@
"see": true
}
},
+ "checkTypes": "strictNativeCase",
"checkParamNames": true,
"checkRedundantAccess": true,
"checkRedundantReturns": true,
diff --git a/modules/ve-mw/dm/nodes/ve.dm.MWReferenceNode.js
b/modules/ve-mw/dm/nodes/ve.dm.MWReferenceNode.js
index 703cf95..dc708c8 100644
--- a/modules/ve-mw/dm/nodes/ve.dm.MWReferenceNode.js
+++ b/modules/ve-mw/dm/nodes/ve.dm.MWReferenceNode.js
@@ -253,7 +253,7 @@
* @static
* @param {Object} dataElement Element data
* @param {ve.dm.InternalList} internalList Internal list
- * @return {Number} Index
+ * @return {number} Index
*/
ve.dm.MWReferenceNode.static.getIndex = function ( dataElement, internalList )
{
var listIndex = dataElement.attributes.listIndex,
@@ -313,7 +313,7 @@
/**
* Gets the index for the reference
*
- * @return {Number} Index
+ * @return {number} Index
*/
ve.dm.MWReferenceNode.prototype.getIndex = function () {
return this.constructor.static.getIndex( this.element,
this.getDocument().getInternalList() );
diff --git a/modules/ve-mw/ui/tools/ve.ui.MWPopupTool.js
b/modules/ve-mw/ui/tools/ve.ui.MWPopupTool.js
index cbb5a30..698f39c 100644
--- a/modules/ve-mw/ui/tools/ve.ui.MWPopupTool.js
+++ b/modules/ve-mw/ui/tools/ve.ui.MWPopupTool.js
@@ -12,7 +12,7 @@
* @abstract
* @extends OO.ui.PopupTool
* @constructor
- * @param {String} title Title
+ * @param {string} title Title
* @param {OO.ui.ToolGroup} toolGroup
* @param {Object} [config]
*/
--
To view, visit https://gerrit.wikimedia.org/r/232554
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idbf6e698ba7015ee5e4f1cf78234ad3f187f1c06
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
