Matthias Mullie has uploaded a new change for review.
https://gerrit.wikimedia.org/r/232719
Change subject: Use rc_source instead of rc_type
......................................................................
Use rc_source instead of rc_type
rc_type might end up being dropped (T74157) at some point.
Flow correctly uses rc_source already in most places. There's
a little bit of other code doing things with rc_type (failsafes
for when rc_source wasn't populated and storing correct value
for rc_type) but nothing that will make code fail should rc_type
no longer exist.
This was just a minor occurence in a maint script that would
cause the script to fail should rc_type no longer be around.
Might as well convert that to rc_source as well.
Change-Id: I2e159589ab6c90281f953b79ae0d7dc1b22d25f3
---
M maintenance/FlowUpdateRecentChanges.php
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow
refs/changes/19/232719/1
diff --git a/maintenance/FlowUpdateRecentChanges.php
b/maintenance/FlowUpdateRecentChanges.php
index d1e11c3..df2a6c7 100644
--- a/maintenance/FlowUpdateRecentChanges.php
+++ b/maintenance/FlowUpdateRecentChanges.php
@@ -1,5 +1,7 @@
<?php
+use Flow\Data\Listener\RecentChangesListener;
+
require_once ( getenv( 'MW_INSTALL_PATH' ) !== false
? getenv( 'MW_INSTALL_PATH' ) . '/maintenance/Maintenance.php'
: dirname( __FILE__ ) . '/../../../maintenance/Maintenance.php' );
@@ -49,7 +51,7 @@
$rows = $dbw->select(
/* table */'recentchanges',
/* select */array( 'rc_id', 'rc_params' ),
- /* conds */array( "rc_id > $continue", 'rc_type' =>
RC_FLOW ),
+ /* conds */array( "rc_id > $continue", 'rc_source' =>
RecentChangesListener::SRC_FLOW ),
__METHOD__,
/* options */array( 'LIMIT' => $this->mBatchSize,
'ORDER BY' => 'rc_id' )
);
--
To view, visit https://gerrit.wikimedia.org/r/232719
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2e159589ab6c90281f953b79ae0d7dc1b22d25f3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
