Esanders has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/232773

Change subject: Fix focusable mouseout
......................................................................

Fix focusable mouseout

We should detect mouseout of this.$focusable, not this.$element.

Change-Id: Ifd071eaccdf543a707ef839d5ea0f715e9d2be8c
---
M src/ce/ve.ce.FocusableNode.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/73/232773/1

diff --git a/src/ce/ve.ce.FocusableNode.js b/src/ce/ve.ce.FocusableNode.js
index b4ceaa7..2693d57 100644
--- a/src/ce/ve.ce.FocusableNode.js
+++ b/src/ce/ve.ce.FocusableNode.js
@@ -285,7 +285,7 @@
        var $target = $( e.target );
        if (
                !$target.hasClass( 've-ce-focusableNode-highlight' ) &&
-               $target.closest( '.ve-ce-focusableNode' ).length === 0
+               !OO.ui.contains( this.$focusable.toArray(), $target[ 0 ], true )
        ) {
                this.clearHighlights();
        }

-- 
To view, visit https://gerrit.wikimedia.org/r/232773
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifd071eaccdf543a707ef839d5ea0f715e9d2be8c
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to