Niedzielski has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/233038

Change subject: Preserve descenders in link preview title
......................................................................

Preserve descenders in link preview title

The stems of gs and ys in the link preview title were cut off because
the line height was too trim.

Bug: T109892
Change-Id: I9cb6aa61e78ede0fe0b69617360ab5d0f34ae4f3
---
M app/src/main/res/layout/dialog_link_preview.xml
1 file changed, 1 insertion(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/38/233038/1

diff --git a/app/src/main/res/layout/dialog_link_preview.xml 
b/app/src/main/res/layout/dialog_link_preview.xml
index f55ca9d..3fa9698 100755
--- a/app/src/main/res/layout/dialog_link_preview.xml
+++ b/app/src/main/res/layout/dialog_link_preview.xml
@@ -36,7 +36,6 @@
                     android:layout_marginTop="16dp"
                     android:layout_marginBottom="10dp"
                     android:layout_weight="1"
-                    android:layout_gravity="center_vertical"
                     style="@style/RtlAwareTextView"
                     android:textColor="?attr/link_preview_text_color"
                     android:paddingLeft="16dp"
@@ -44,10 +43,9 @@
                     android:paddingBottom="4dp"
                     android:textSize="22sp"
                     android:fontFamily="serif"
-                    android:lineSpacingMultiplier="0.9"
                     android:maxLines="2"
                     android:ellipsize="end"
-                    tools:text="Lorem ipsum"/>
+                    tools:text="Lorem ipsum" />
                 <ImageView
                     android:id="@+id/link_preview_overflow_button"
                     android:layout_width="48dp"

-- 
To view, visit https://gerrit.wikimedia.org/r/233038
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9cb6aa61e78ede0fe0b69617360ab5d0f34ae4f3
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to