jenkins-bot has submitted this change and it was merged.
Change subject: Preserve descenders in link preview title
......................................................................
Preserve descenders in link preview title
The stems of gs and ys in the link preview title were cut off because
the line height was too trim.
Bug: T109892
Change-Id: I9cb6aa61e78ede0fe0b69617360ab5d0f34ae4f3
---
M app/src/main/java/org/wikipedia/page/linkpreview/LinkPreviewDialog.java
M app/src/main/res/layout/dialog_link_preview.xml
2 files changed, 3 insertions(+), 4 deletions(-)
Approvals:
BearND: Looks good to me, approved
jenkins-bot: Verified
diff --git
a/app/src/main/java/org/wikipedia/page/linkpreview/LinkPreviewDialog.java
b/app/src/main/java/org/wikipedia/page/linkpreview/LinkPreviewDialog.java
index 3207bf4..b34878a 100755
--- a/app/src/main/java/org/wikipedia/page/linkpreview/LinkPreviewDialog.java
+++ b/app/src/main/java/org/wikipedia/page/linkpreview/LinkPreviewDialog.java
@@ -93,8 +93,8 @@
rootView.findViewById(R.id.link_preview_toolbar).setOnClickListener(goToPageListener);
TextView titleText = (TextView)
rootView.findViewById(R.id.link_preview_title);
titleText.setText(pageTitle.getDisplayText());
- if (!ApiUtil.hasHoneyComb()) {
- // for GB, reset line spacing to 1, since it doesn't handle <1
very well.
+ if (!ApiUtil.hasKitKat()) {
+ // for oldish devices, reset line spacing to 1, since it truncates
the descenders.
titleText.setLineSpacing(0, 1.0f);
} else if (!ApiUtil.hasLollipop()) {
// for <5.0, give the title a bit more bottom padding, since these
versions
diff --git a/app/src/main/res/layout/dialog_link_preview.xml
b/app/src/main/res/layout/dialog_link_preview.xml
index f55ca9d..81f89e3 100755
--- a/app/src/main/res/layout/dialog_link_preview.xml
+++ b/app/src/main/res/layout/dialog_link_preview.xml
@@ -36,7 +36,6 @@
android:layout_marginTop="16dp"
android:layout_marginBottom="10dp"
android:layout_weight="1"
- android:layout_gravity="center_vertical"
style="@style/RtlAwareTextView"
android:textColor="?attr/link_preview_text_color"
android:paddingLeft="16dp"
@@ -47,7 +46,7 @@
android:lineSpacingMultiplier="0.9"
android:maxLines="2"
android:ellipsize="end"
- tools:text="Lorem ipsum"/>
+ tools:text="Lorem ipsum" />
<ImageView
android:id="@+id/link_preview_overflow_button"
android:layout_width="48dp"
--
To view, visit https://gerrit.wikimedia.org/r/233038
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9cb6aa61e78ede0fe0b69617360ab5d0f34ae4f3
Gerrit-PatchSet: 4
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <[email protected]>
Gerrit-Reviewer: BearND <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Dbrant <[email protected]>
Gerrit-Reviewer: Mholloway <[email protected]>
Gerrit-Reviewer: Niedzielski <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
