Glaisher has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/234854

Change subject: SpecialGlobalRenameRequest: use $this->requireLogin() instead 
of our own code
......................................................................

SpecialGlobalRenameRequest: use $this->requireLogin() instead of our own code

It will also now show a message on the login form; previously there was
no message.

Change-Id: I63577fedae1d3797b6b63ebedebe7acdaebaad5a
---
M includes/specials/SpecialGlobalRenameRequest.php
1 file changed, 1 insertion(+), 9 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralAuth 
refs/changes/54/234854/1

diff --git a/includes/specials/SpecialGlobalRenameRequest.php 
b/includes/specials/SpecialGlobalRenameRequest.php
index c43a75b..1c4fe42 100644
--- a/includes/specials/SpecialGlobalRenameRequest.php
+++ b/includes/specials/SpecialGlobalRenameRequest.php
@@ -35,15 +35,7 @@
         * @param string $par Subpage string if one was specified
         */
        public function execute( $par ) {
-               if ( !$this->getUser()->isLoggedIn() ) {
-                       // Require user to be logged in
-                       $loginpage = SpecialPage::getTitleFor( 'Userlogin' );
-                       $loginurl = $loginpage->getFullUrl(
-                               array( 'returnto' => 
$this->getPageTitle()->getPrefixedText() )
-                       );
-                       $this->getOutput()->redirect( $loginurl );
-                       return;
-               }
+               $this->requireLogin();
 
                switch ( $par ) {
                        case 'status':

-- 
To view, visit https://gerrit.wikimedia.org/r/234854
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I63577fedae1d3797b6b63ebedebe7acdaebaad5a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralAuth
Gerrit-Branch: master
Gerrit-Owner: Glaisher <glaisher.w...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to