jenkins-bot has submitted this change and it was merged.
Change subject: Fix unchecked loop in wikibase.special.itemByTitle
......................................................................
Fix unchecked loop in wikibase.special.itemByTitle
Change-Id: I8e0ef480d257a2d6f065e4c56670c3711cebe4a2
---
M repo/resources/wikibase.special/wikibase.special.itemByTitle.js
1 file changed, 6 insertions(+), 4 deletions(-)
Approvals:
Jonas Kress (WMDE): Looks good to me, approved
jenkins-bot: Verified
diff --git a/repo/resources/wikibase.special/wikibase.special.itemByTitle.js
b/repo/resources/wikibase.special/wikibase.special.itemByTitle.js
index 3801368..5ea4d7b 100644
--- a/repo/resources/wikibase.special/wikibase.special.itemByTitle.js
+++ b/repo/resources/wikibase.special/wikibase.special.itemByTitle.js
@@ -15,10 +15,12 @@
}
// this will build a drop-down for the language selection:
- var siteList = [];
- for( var siteId in wb.sites.getSites() ) {
- var site = wb.sites.getSite( siteId );
- siteList.push( site.getName() + ' (' + site.getId() +
')' );
+ var sites = wb.sites.getSites(),
+ siteList = [];
+ for( var siteId in sites ) {
+ if( sites.hasOwnProperty( siteId ) ) {
+ siteList.push( sites[ siteId ].getName() + ' ('
+ siteId + ')' );
+ }
}
$( '#wb-itembytitle-sitename' )
.attr( 'autocomplete', 'off' )
--
To view, visit https://gerrit.wikimedia.org/r/232482
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8e0ef480d257a2d6f065e4c56670c3711cebe4a2
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: Jonas Kress (WMDE) <[email protected]>
Gerrit-Reviewer: Ricordisamoa <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: WMDE-Fisch <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
