jenkins-bot has submitted this change and it was merged.
Change subject: Add array type hints to GenericEntityInfoBuilder classes
......................................................................
Add array type hints to GenericEntityInfoBuilder classes
Change-Id: I922065c691c054f2173ea3dc1f17ada289673fec
---
M lib/includes/store/GenericEntityInfoBuilder.php
M lib/includes/store/sql/SqlEntityInfoBuilder.php
2 files changed, 7 insertions(+), 2 deletions(-)
Approvals:
Jeroen De Dauw: Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/includes/store/GenericEntityInfoBuilder.php
b/lib/includes/store/GenericEntityInfoBuilder.php
index 3185aea..0745b8b 100644
--- a/lib/includes/store/GenericEntityInfoBuilder.php
+++ b/lib/includes/store/GenericEntityInfoBuilder.php
@@ -183,7 +183,12 @@
}
}
- private function injectFingerprint( $types, array &$entityRecord,
Fingerprint $fingerprint, $languages ) {
+ private function injectFingerprint(
+ array $types = null,
+ array &$entityRecord,
+ Fingerprint $fingerprint,
+ array $languages = null
+ ) {
if ( $types === null || in_array( 'label', $types ) ) {
$labels = $fingerprint->getLabels();
diff --git a/lib/includes/store/sql/SqlEntityInfoBuilder.php
b/lib/includes/store/sql/SqlEntityInfoBuilder.php
index 27ce3b6..fb8108b 100644
--- a/lib/includes/store/sql/SqlEntityInfoBuilder.php
+++ b/lib/includes/store/sql/SqlEntityInfoBuilder.php
@@ -616,7 +616,7 @@
*
* @return array
*/
- private function ungroup( $groupedArrays ) {
+ private function ungroup( array $groupedArrays ) {
$merged = array_reduce(
$groupedArrays,
function ( $acc, $next ) {
--
To view, visit https://gerrit.wikimedia.org/r/233351
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I922065c691c054f2173ea3dc1f17ada289673fec
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
