Mholloway has uploaded a new change for review. https://gerrit.wikimedia.org/r/235281
Change subject: Suppress link previews for non-mainspace links ...................................................................... Suppress link previews for non-mainspace links Currently, link previews are shown for non-mainspace pages (including File, Wikipedia, and Portal), which isn't the behavior we want. This patch adds a check for null namespace (i.e., mainspace) before showing a link preview. Bug: T108377 Change-Id: Ic6f29c2f25762d004f32bcbd8cc9142b1f3cd0fc --- M app/src/main/java/org/wikipedia/page/PageFragment.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia refs/changes/81/235281/1 diff --git a/app/src/main/java/org/wikipedia/page/PageFragment.java b/app/src/main/java/org/wikipedia/page/PageFragment.java index dcdaf62..e169897 100755 --- a/app/src/main/java/org/wikipedia/page/PageFragment.java +++ b/app/src/main/java/org/wikipedia/page/PageFragment.java @@ -400,7 +400,7 @@ if (referenceDialog != null && referenceDialog.isShowing()) { referenceDialog.dismiss(); } - if (!app.isProdRelease() && app.getLinkPreviewVersion() == 0) { + if (title.getNamespace() != null || (!app.isProdRelease() && app.getLinkPreviewVersion() == 0)) { HistoryEntry historyEntry = new HistoryEntry(title, HistoryEntry.SOURCE_INTERNAL_LINK); getPageActivity().displayNewPage(title, historyEntry); new LinkPreviewFunnel(app).logNavigate(); -- To view, visit https://gerrit.wikimedia.org/r/235281 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic6f29c2f25762d004f32bcbd8cc9142b1f3cd0fc Gerrit-PatchSet: 1 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: Mholloway <mhollo...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits