Amire80 has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/236039

Change subject: Remove invalid call to .showSourceSelector()
......................................................................

Remove invalid call to .showSourceSelector()

This function doesn't exist since
Ie368d66533337167fdaf7ffe32caf6bad220c836

It was replaced in that commit with .showDashboard().

However, it is better not to go to the dashboard here,
so that the user would see the error.

Bug: T111538
Change-Id: I750f3a9ec0ea0c74155c84b1a6c2c8a3091f8cd9
---
M modules/source/ext.cx.source.js
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation 
refs/changes/39/236039/1

diff --git a/modules/source/ext.cx.source.js b/modules/source/ext.cx.source.js
index 5861cdd..b2b27cb 100644
--- a/modules/source/ext.cx.source.js
+++ b/modules/source/ext.cx.source.js
@@ -76,7 +76,6 @@
                                        mw.hook( 'mw.cx.error' ).fire(
                                                mw.msg( 
'cx-error-page-not-found', title, $.uls.data.getAutonym( language ) )
                                        );
-                                       cxSource.showSourceSelector();
                                } else {
                                        mw.hook( 'mw.cx.error' ).fire( mw.msg( 
'cx-error-server-connection' ) );
                                }

-- 
To view, visit https://gerrit.wikimedia.org/r/236039
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I750f3a9ec0ea0c74155c84b1a6c2c8a3091f8cd9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Amire80 <amir.ahar...@mail.huji.ac.il>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to