jenkins-bot has submitted this change and it was merged.
Change subject: Remove invalid call to .showSourceSelector()
......................................................................
Remove invalid call to .showSourceSelector()
This function doesn't exist since
Ie368d66533337167fdaf7ffe32caf6bad220c836
It was replaced in that commit with .showDashboard().
However, it is better not to go to the dashboard here,
so that the user would see the error.
Bug: T111538
Change-Id: I750f3a9ec0ea0c74155c84b1a6c2c8a3091f8cd9
---
M modules/source/ext.cx.source.js
1 file changed, 1 insertion(+), 3 deletions(-)
Approvals:
Nikerabbit: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/source/ext.cx.source.js b/modules/source/ext.cx.source.js
index 5861cdd..e6a4fdf 100644
--- a/modules/source/ext.cx.source.js
+++ b/modules/source/ext.cx.source.js
@@ -59,8 +59,7 @@
* identify the host wiki.
*/
ContentTranslationSource.prototype.fetchPage = function ( title,
language ) {
- var fetchPageUrl,
- cxSource = this;
+ var fetchPageUrl;
fetchPageUrl = this.siteMapper.getCXServerUrl(
'/page/$language/$title', {
$language: this.siteMapper.getWikiDomainCode( language
),
@@ -76,7 +75,6 @@
mw.hook( 'mw.cx.error' ).fire(
mw.msg(
'cx-error-page-not-found', title, $.uls.data.getAutonym( language ) )
);
- cxSource.showSourceSelector();
} else {
mw.hook( 'mw.cx.error' ).fire( mw.msg(
'cx-error-server-connection' ) );
}
--
To view, visit https://gerrit.wikimedia.org/r/236039
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I750f3a9ec0ea0c74155c84b1a6c2c8a3091f8cd9
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Amire80 <amir.ahar...@mail.huji.ac.il>
Gerrit-Reviewer: Nikerabbit <niklas.laxst...@gmail.com>
Gerrit-Reviewer: Santhosh <santhosh.thottin...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
