jenkins-bot has submitted this change and it was merged.
Change subject: Go back to using a configurable link for documentation
......................................................................
Go back to using a configurable link for documentation
The message allows per-wiki configuration. The default target is better
for normal users of TemplateData than the previous hard-coded one and
has already been translated in some languages from when it was used
previously.
This also moves the messages dependencies from `ext.templateData` to
`ext.templateDataGenerator.ui`, which is the only module that uses
them: the correct strings were displayed only by inheritance.
Bug: T112011
Change-Id: I81ab684bb0ed9b0767df75635284c51129ac7000
---
M extension.json
M modules/ext.templateDataGenerator.ui.js
2 files changed, 6 insertions(+), 8 deletions(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/extension.json b/extension.json
index ebb0814..f150e2b 100644
--- a/extension.json
+++ b/extension.json
@@ -61,12 +61,6 @@
],
"dependencies": [
"ext.templateDataGenerator.ui"
- ],
- "messages": [
- "templatedata-editbutton",
- "templatedata-helplink",
- "templatedata-helplink-target",
- "templatedata-errormsg-jsonbadformat"
]
},
"ext.templateDataGenerator.data": {
@@ -99,6 +93,8 @@
"messages": [
"comma-separator",
"templatedata-doc-no-params-set",
+ "templatedata-editbutton",
+ "templatedata-errormsg-jsonbadformat",
"templatedata-exists-on-related-page",
"templatedata-modal-button-add-language",
"templatedata-modal-button-addparam",
@@ -153,7 +149,9 @@
"templatedata-modal-title-paramorder",
"templatedata-modal-title-templatedesc",
"templatedata-modal-title-templateparam-details",
- "templatedata-modal-title-templateparams"
+ "templatedata-modal-title-templateparams",
+ "templatedata-helplink",
+ "templatedata-helplink-target"
]
}
},
diff --git a/modules/ext.templateDataGenerator.ui.js
b/modules/ext.templateDataGenerator.ui.js
index 28441f4..d0cc9a8 100644
--- a/modules/ext.templateDataGenerator.ui.js
+++ b/modules/ext.templateDataGenerator.ui.js
@@ -203,7 +203,7 @@
editHelpButtonWidget = new OO.ui.ButtonWidget( {
label: mw.msg( 'templatedata-helplink'
),
classes: [
'tdg-editscreen-main-helplink' ],
- href:
'https://www.mediawiki.org/wiki/Extension:TemplateData',
+ href: mw.msg(
'templatedata-helplink-target' ),
target: '_blank',
framed: false
} );
--
To view, visit https://gerrit.wikimedia.org/r/237511
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I81ab684bb0ed9b0767df75635284c51129ac7000
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/TemplateData
Gerrit-Branch: master
Gerrit-Owner: Ltrlg <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Mooeypoo <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
