Ori.livneh has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/237515

Change subject: Workaround for IE CSS hack incompatibility with LESS parsers
......................................................................

Workaround for IE CSS hack incompatibility with LESS parsers

`oyejorge/less.php` is an alternate LESS library for PHP that I am hoping to
use to replace lessphp (see T112035). It chokes on literal '\9' in CSS rules,
but this limitation is easy to work around via a variable.

Change-Id: I015ac022c575fc09fa7dab0d4084ee9de4c563f8
---
M resources/src/mediawiki.less/mediawiki.mixins.less
1 file changed, 6 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/15/237515/1

diff --git a/resources/src/mediawiki.less/mediawiki.mixins.less 
b/resources/src/mediawiki.less/mediawiki.mixins.less
index e947775..bbcc75b 100644
--- a/resources/src/mediawiki.less/mediawiki.mixins.less
+++ b/resources/src/mediawiki.less/mediawiki.mixins.less
@@ -8,6 +8,11 @@
 //
 // See <http://lesscss.org/#-mixins> for more information about how to write 
mixins.
 
+// Some LESS parsers choke on the '\9' CSS hack. It is possible to route
+// around this limitation by assigning '\9' to a variable and using the
+// variable wherever the literal '\9' is desired.
+@slashNine: \9;
+
 .background-image(@url) {
        background-image: e('/* @embed */') url(@url);
 }
@@ -52,7 +57,7 @@
 .list-style-image-svg(@svg, @fallback) {
        list-style-image: e('/* @embed */') url(@svg);
        /* Fallback to PNG bullet for IE 8 and below using CSS hack */
-       list-style-image: e('/* @embed */') url(@fallback)\9;
+       list-style-image: e('/* @embed */') url(@fallback)@slashNine;
 }
 
 .transition(@value) {

-- 
To view, visit https://gerrit.wikimedia.org/r/237515
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I015ac022c575fc09fa7dab0d4084ee9de4c563f8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to