Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/237517
Change subject: Restyle buttons to be fully clickable
......................................................................
Restyle buttons to be fully clickable
Also use framed buttons (which these sort of are) as they
have hover styles.
Bug: T112188
Change-Id: I750a18a90c655cc7916e050b5e300300a4437b69
---
M modules/ooui/mw.echo.ui.NotificationBadgeWidget.js
M modules/ooui/styles/mw.echo.ui.NotificationBadgeWidget.less
2 files changed, 9 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo
refs/changes/17/237517/1
diff --git a/modules/ooui/mw.echo.ui.NotificationBadgeWidget.js
b/modules/ooui/mw.echo.ui.NotificationBadgeWidget.js
index caeb795..8ca916a 100644
--- a/modules/ooui/mw.echo.ui.NotificationBadgeWidget.js
+++ b/modules/ooui/mw.echo.ui.NotificationBadgeWidget.js
@@ -62,7 +62,6 @@
// Footer
allNotificationsButton = new OO.ui.ButtonWidget( {
- framed: false,
icon: 'next',
label: mw.msg( 'echo-overlay-link' ),
href: config.links.notifications,
@@ -70,7 +69,6 @@
} );
preferencesButton = new OO.ui.ButtonWidget( {
- framed: false,
icon: 'advanced',
label: mw.msg( 'mypreferences' ),
href: config.links.preferences,
diff --git a/modules/ooui/styles/mw.echo.ui.NotificationBadgeWidget.less
b/modules/ooui/styles/mw.echo.ui.NotificationBadgeWidget.less
index 81128dd..4d43850 100644
--- a/modules/ooui/styles/mw.echo.ui.NotificationBadgeWidget.less
+++ b/modules/ooui/styles/mw.echo.ui.NotificationBadgeWidget.less
@@ -24,14 +24,21 @@
display: table-cell;
white-space: normal;
font-weight: bold;
- padding: 1em;
- padding-left: 2em;
width: @notification-popup-width / 2;
box-sizing: border-box;
&:last-child {
border-left: 1px solid #DDDDDD;
}
+
+ > .oo-ui-buttonElement-button {
+ display: block;
+ line-height: 4em;
+ text-align: left;
+ padding: 0 1em 0 2em;
+ margin: 0;
+ border: 0;
+ }
}
}
--
To view, visit https://gerrit.wikimedia.org/r/237517
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I750a18a90c655cc7916e050b5e300300a4437b69
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
