jenkins-bot has submitted this change and it was merged.
Change subject: ext.centralNotice.display: public getData() -> getDataProperty()
......................................................................
ext.centralNotice.display: public getData() -> getDataProperty()
Renames the public getData() method, since it's easily confused with the method
with the same name on the state object.
Change-Id: I3e16414a82cdd4e22f8b418bfabd024c70e455d5
---
M resources/subscribing/ext.centralNotice.display.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Awight: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/subscribing/ext.centralNotice.display.js
b/resources/subscribing/ext.centralNotice.display.js
index dd5dddb..d709dfd 100644
--- a/resources/subscribing/ext.centralNotice.display.js
+++ b/resources/subscribing/ext.centralNotice.display.js
@@ -530,7 +530,7 @@
* Get the value of a property used in campaign/banner
selection and
* display, and for recording the results of that process.
*/
- getData: function( prop ) {
+ getDataProperty: function( prop ) {
return cn.internal.state.getData()[prop];
}
};
--
To view, visit https://gerrit.wikimedia.org/r/243604
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3e16414a82cdd4e22f8b418bfabd024c70e455d5
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: AndyRussG <[email protected]>
Gerrit-Reviewer: Awight <[email protected]>
Gerrit-Reviewer: Cdentinger <[email protected]>
Gerrit-Reviewer: Ejegg <[email protected]>
Gerrit-Reviewer: Ssmith <[email protected]>
Gerrit-Reviewer: XenoRyet <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
