[MediaWiki-commits] [Gerrit] Flip if else - change (mediawiki...Wikibase)

[Jeroen De Dauw (Code Review)]

Jeroen De Dauw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/245601

Change subject: Flip if else
......................................................................

Flip if else

Change-Id: I1f4b2efe90be7dfc24296907d15e6a1e262ab161
---
M repo/includes/store/sql/SqlChangeStore.php
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/01/245601/1

diff --git a/repo/includes/store/sql/SqlChangeStore.php 
b/repo/includes/store/sql/SqlChangeStore.php
index 2816989..ef4462c 100644
--- a/repo/includes/store/sql/SqlChangeStore.php
+++ b/repo/includes/store/sql/SqlChangeStore.php
@@ -41,10 +41,10 @@
        public function saveChange( Change $change ) {
                Assert::parameterType( 'Wikibase\ChangeRow', $change, '$change' 
);
 
-               if ( $change->getId() !== null ) {
-                       $this->updateChange( $change );
-               } else {
+               if ( $change->getId() === null ) {
                        $this->insertChange( $change );
+               } else {
+                       $this->updateChange( $change );
                }
        }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/245601
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1f4b2efe90be7dfc24296907d15e6a1e262ab161
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <jeroended...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits