jenkins-bot has submitted this change and it was merged.
Change subject: Flip if else
......................................................................
Flip if else
Change-Id: I1f4b2efe90be7dfc24296907d15e6a1e262ab161
---
M repo/includes/store/sql/SqlChangeStore.php
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Hoo man: Looks good to me, approved
Daniel Kinzler: Looks good to me, approved
Addshore: Looks good to me, approved
jenkins-bot: Verified
diff --git a/repo/includes/store/sql/SqlChangeStore.php
b/repo/includes/store/sql/SqlChangeStore.php
index dde9d3f..1761743 100644
--- a/repo/includes/store/sql/SqlChangeStore.php
+++ b/repo/includes/store/sql/SqlChangeStore.php
@@ -41,10 +41,10 @@
public function saveChange( Change $change ) {
Assert::parameterType( 'Wikibase\ChangeRow', $change, '$change'
);
- if ( $change->getId() !== null ) {
- $this->updateChange( $change );
- } else {
+ if ( $change->getId() === null ) {
$this->insertChange( $change );
+ } else {
+ $this->updateChange( $change );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/245601
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1f4b2efe90be7dfc24296907d15e6a1e262ab161
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: Daniel Kinzler <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
