TheDJ has uploaded a new change for review.
https://gerrit.wikimedia.org/r/247548
Change subject: Do not throw errors on audio-only MP4 files
......................................................................
Do not throw errors on audio-only MP4 files
Bug: T115197
Change-Id: I45df550d2bd39b422ce56de1d5e49112b1256c87
---
M handlers/Mp4Handler/Mp4Handler.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler
refs/changes/48/247548/1
diff --git a/handlers/Mp4Handler/Mp4Handler.php
b/handlers/Mp4Handler/Mp4Handler.php
index 897e101..21a73ca 100644
--- a/handlers/Mp4Handler/Mp4Handler.php
+++ b/handlers/Mp4Handler/Mp4Handler.php
@@ -92,7 +92,7 @@
}
}
// id3 gives 'V_VP8' for what we call VP8
- if( $metadata['video']['dataformat'] == 'quicktime' ){
+ if( isset( $metadata['video'] ) &&
$metadata['video']['dataformat'] == 'quicktime' ){
$streamTypes[] = 'h.264';
}
--
To view, visit https://gerrit.wikimedia.org/r/247548
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I45df550d2bd39b422ce56de1d5e49112b1256c87
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: TheDJ <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
