jenkins-bot has submitted this change and it was merged.
Change subject: Do not throw errors on audio-only MP4 files
......................................................................
Do not throw errors on audio-only MP4 files
Bug: T115197
Change-Id: I45df550d2bd39b422ce56de1d5e49112b1256c87
---
M handlers/Mp4Handler/Mp4Handler.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Brion VIBBER: Looks good to me, approved
jenkins-bot: Verified
diff --git a/handlers/Mp4Handler/Mp4Handler.php
b/handlers/Mp4Handler/Mp4Handler.php
index 897e101..21a73ca 100644
--- a/handlers/Mp4Handler/Mp4Handler.php
+++ b/handlers/Mp4Handler/Mp4Handler.php
@@ -92,7 +92,7 @@
}
}
// id3 gives 'V_VP8' for what we call VP8
- if( $metadata['video']['dataformat'] == 'quicktime' ){
+ if( isset( $metadata['video'] ) &&
$metadata['video']['dataformat'] == 'quicktime' ){
$streamTypes[] = 'h.264';
}
--
To view, visit https://gerrit.wikimedia.org/r/247548
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I45df550d2bd39b422ce56de1d5e49112b1256c87
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: TheDJ <hartman.w...@gmail.com>
Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
