jenkins-bot has submitted this change and it was merged.
Change subject: Suppress delete button (icon) if history is empty
......................................................................
Suppress delete button (icon) if history is empty
Bug: T116431
Change-Id: I71e0437fb92497e1c7c12e1c5faa84e0eff58ba0
---
M app/src/main/java/org/wikipedia/history/HistoryFragment.java
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Sniedzielski: Looks good to me, approved
jenkins-bot: Verified
diff --git a/app/src/main/java/org/wikipedia/history/HistoryFragment.java
b/app/src/main/java/org/wikipedia/history/HistoryFragment.java
index 5eecf48..bfddbef 100644
--- a/app/src/main/java/org/wikipedia/history/HistoryFragment.java
+++ b/app/src/main/java/org/wikipedia/history/HistoryFragment.java
@@ -312,7 +312,9 @@
if (!isAdded() || ((PageActivity)getActivity()).isSearching()) {
return;
}
-
menu.findItem(R.id.menu_clear_all_history).setEnabled(historyEntryList.getCount()
> 0);
+ menu.findItem(R.id.menu_clear_all_history)
+ .setVisible(historyEntryList.getCount() > 0)
+ .setEnabled(historyEntryList.getCount() > 0);
}
@Override
--
To view, visit https://gerrit.wikimedia.org/r/248479
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I71e0437fb92497e1c7c12e1c5faa84e0eff58ba0
Gerrit-PatchSet: 2
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Wikinaut <[email protected]>
Gerrit-Reviewer: BearND <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Dbrant <[email protected]>
Gerrit-Reviewer: Florianschmidtwelzow <[email protected]>
Gerrit-Reviewer: Mholloway <[email protected]>
Gerrit-Reviewer: Niedzielski <[email protected]>
Gerrit-Reviewer: Sniedzielski <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
