tosfos has uploaded a new change for review.
https://gerrit.wikimedia.org/r/249575
Change subject: Bugfix: Make sure ads are defined for this page
......................................................................
Bugfix: Make sure ads are defined for this page
Bug: T112427
Change-Id: I215fc558d4ea3622e19717e958831d8ee5f510fd
---
M AdManager.hooks.php
M AdManager.php
2 files changed, 7 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/AdManager
refs/changes/75/249575/1
diff --git a/AdManager.hooks.php b/AdManager.hooks.php
index c32bbc7..9a66523 100644
--- a/AdManager.hooks.php
+++ b/AdManager.hooks.php
@@ -55,6 +55,12 @@
}
$adsOut = AdManager::getAdOutputFor( $skin->getTitle() );
+
+ if ( !$adsOut ) {
+ // No ads. Nothing to do.
+ return true;
+ }
+
foreach ( $adsOut as $adNumber => $adOut ) {
$out->prependHTML( Html::rawelement( 'div',
array( 'id' =>
"AdManager-content-$adNumber", 'class' => 'AdManager-content' ), $adOut ) );
diff --git a/AdManager.php b/AdManager.php
index e8ca2e3..6541879 100644
--- a/AdManager.php
+++ b/AdManager.php
@@ -21,7 +21,7 @@
$wgExtensionCredits['specialpage'][] = array(
'path' => __FILE__,
'name' => 'AdManager',
- 'version' => '1.0.0',
+ 'version' => '1.1.0',
'author' => 'Ike Hecht for WikiWorks',
'url' => 'https://www.mediawiki.org/wiki/Extension:AdManager',
'descriptionmsg' => 'admanager-desc',
--
To view, visit https://gerrit.wikimedia.org/r/249575
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I215fc558d4ea3622e19717e958831d8ee5f510fd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/AdManager
Gerrit-Branch: master
Gerrit-Owner: tosfos <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
