BBlack has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/249577

Change subject: cipher_sim: fix match ordering (server pref first)
......................................................................

cipher_sim: fix match ordering (server pref first)

Change-Id: I28edc37b2afa4fee250ec5fe074fd21da0b35d0f
---
M modules/tlsproxy/files/utils/cipher_sim.py
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/77/249577/1

diff --git a/modules/tlsproxy/files/utils/cipher_sim.py 
b/modules/tlsproxy/files/utils/cipher_sim.py
index da098f6..8d6957a 100755
--- a/modules/tlsproxy/files/utils/cipher_sim.py
+++ b/modules/tlsproxy/files/utils/cipher_sim.py
@@ -110,8 +110,8 @@
 
 
 def get_choice(client_ciphers, server_pref):
-    for c in client_ciphers:
-        for servc in server_pref:
+    for servc in server_pref:
+        for c in client_ciphers:
             if int(c) == servc[0]:
                 return servc[1]
     return ":HANDSHAKE-FAILURE:"

-- 
To view, visit https://gerrit.wikimedia.org/r/249577
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I28edc37b2afa4fee250ec5fe074fd21da0b35d0f
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: BBlack <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to