jenkins-bot has submitted this change and it was merged.
Change subject: build: Enable phpcs rule
'PSR2.Methods.MethodDeclaration.AbstractAfterVisibility' and make pass
......................................................................
build: Enable phpcs rule
'PSR2.Methods.MethodDeclaration.AbstractAfterVisibility' and make pass
Change-Id: I316d30e5474646cfc7a8a03b540c09741cd7fdc6
---
M includes/formatters/NotificationFormatter.php
M phpcs.xml
2 files changed, 1 insertion(+), 2 deletions(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/formatters/NotificationFormatter.php
b/includes/formatters/NotificationFormatter.php
index 1b9d3db..f0f03eb 100644
--- a/includes/formatters/NotificationFormatter.php
+++ b/includes/formatters/NotificationFormatter.php
@@ -54,7 +54,7 @@
* @return Mixed; depends on output format
* @see EchoNotificationFormatter::setOutputFormat
*/
- public abstract function format( $event, $user, $type );
+ abstract public function format( $event, $user, $type );
/**
* Set the output format that the notification will be displayed in.
diff --git a/phpcs.xml b/phpcs.xml
index 0f5b7a9..11a5228 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -8,7 +8,6 @@
<exclude
name="MediaWiki.WhiteSpace.SpaceAfterControlStructure.Incorrect"/>
<exclude name="PSR2.Classes.PropertyDeclaration.ScopeMissing"/>
<exclude name="PSR2.Classes.PropertyDeclaration.VarUsed"/>
- <exclude
name="PSR2.Methods.MethodDeclaration.AbstractAfterVisibility"/>
<exclude
name="PSR2.Methods.MethodDeclaration.StaticBeforeVisibility"/>
<exclude name="Squiz.Classes.ValidClassName.NotCamelCaps"/>
</rule>
--
To view, visit https://gerrit.wikimedia.org/r/249775
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I316d30e5474646cfc7a8a03b540c09741cd7fdc6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Jforrester <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
