Ori.livneh has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/250152

Change subject: objectcache: Use singleton cache in newAccelerator()
......................................................................

objectcache: Use singleton cache in newAccelerator()

It was re-creating objects for each call.

This matches behaviour of newAnything().

Bug: T115729
Change-Id: If12aedae7f9f791eb8e233eb241c12efd2921762
---
M includes/objectcache/ObjectCache.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/52/250152/1

diff --git a/includes/objectcache/ObjectCache.php 
b/includes/objectcache/ObjectCache.php
index 59c3c1f..3d14c33 100644
--- a/includes/objectcache/ObjectCache.php
+++ b/includes/objectcache/ObjectCache.php
@@ -269,7 +269,7 @@
                        }
                        $id = $fallback;
                }
-               return self::newFromId( $id );
+               return self::getInstance( $id );
        }
 
        /**

-- 
To view, visit https://gerrit.wikimedia.org/r/250152
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If12aedae7f9f791eb8e233eb241c12efd2921762
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.27.0-wmf.4
Gerrit-Owner: Ori.livneh <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to