jenkins-bot has submitted this change and it was merged.
Change subject: objectcache: Use singleton cache in newAccelerator()
......................................................................
objectcache: Use singleton cache in newAccelerator()
It was re-creating objects for each call.
This matches behaviour of newAnything().
Bug: T115729
Change-Id: If12aedae7f9f791eb8e233eb241c12efd2921762
---
M includes/objectcache/ObjectCache.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Aaron Schulz: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/objectcache/ObjectCache.php
b/includes/objectcache/ObjectCache.php
index 59c3c1f..3d14c33 100644
--- a/includes/objectcache/ObjectCache.php
+++ b/includes/objectcache/ObjectCache.php
@@ -269,7 +269,7 @@
}
$id = $fallback;
}
- return self::newFromId( $id );
+ return self::getInstance( $id );
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/250149
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If12aedae7f9f791eb8e233eb241c12efd2921762
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
Gerrit-Reviewer: Aaron Schulz <[email protected]>
Gerrit-Reviewer: BryanDavis <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
