Umherirrender has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/250190

Change subject: Load 'mediawiki.page.gallery.styles' also without javascript
......................................................................

Load 'mediawiki.page.gallery.styles' also without javascript

Using OutputPage::addModules lets the style loaded over javascript
Using OutputPage::addModuleStyles forces loading over css

Change-Id: I3ddf105d180336b6eb7ae31286221151055e649f
---
M includes/gallery/TraditionalImageGallery.php
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/90/250190/1

diff --git a/includes/gallery/TraditionalImageGallery.php 
b/includes/gallery/TraditionalImageGallery.php
index 0934f6a..181c7b8 100644
--- a/includes/gallery/TraditionalImageGallery.php
+++ b/includes/gallery/TraditionalImageGallery.php
@@ -46,12 +46,13 @@
                        array( 'class' => 'gallery mw-gallery-' . $this->mMode 
), $this->mAttribs );
 
                $modules = $this->getModules();
-               $modules[] = 'mediawiki.page.gallery.styles';
 
                if ( $this->mParser ) {
                        $this->mParser->getOutput()->addModules( $modules );
+                       $this->mParser->getOutput()->addModuleStyles( 
'mediawiki.page.gallery.styles' );
                } else {
                        $this->getOutput()->addModules( $modules );
+                       $this->getOutput()->addModuleStyles( 
'mediawiki.page.gallery.styles' );
                }
                $output = Xml::openElement( 'ul', $attribs );
                if ( $this->mCaption ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/250190
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3ddf105d180336b6eb7ae31286221151055e649f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to