jenkins-bot has submitted this change and it was merged.
Change subject: Load 'mediawiki.page.gallery.styles' also without javascript
......................................................................
Load 'mediawiki.page.gallery.styles' also without javascript
Using OutputPage::addModules lets the style loaded over javascript
Using OutputPage::addModuleStyles forces loading over css
Follows I32697c2c65824d7622c1840330d6074ebb68b488
Bug: T117328
Change-Id: I3ddf105d180336b6eb7ae31286221151055e649f
---
M includes/gallery/TraditionalImageGallery.php
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
TheDJ: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/gallery/TraditionalImageGallery.php
b/includes/gallery/TraditionalImageGallery.php
index 0934f6a..181c7b8 100644
--- a/includes/gallery/TraditionalImageGallery.php
+++ b/includes/gallery/TraditionalImageGallery.php
@@ -46,12 +46,13 @@
array( 'class' => 'gallery mw-gallery-' . $this->mMode
), $this->mAttribs );
$modules = $this->getModules();
- $modules[] = 'mediawiki.page.gallery.styles';
if ( $this->mParser ) {
$this->mParser->getOutput()->addModules( $modules );
+ $this->mParser->getOutput()->addModuleStyles(
'mediawiki.page.gallery.styles' );
} else {
$this->getOutput()->addModules( $modules );
+ $this->getOutput()->addModuleStyles(
'mediawiki.page.gallery.styles' );
}
$output = Xml::openElement( 'ul', $attribs );
if ( $this->mCaption ) {
--
To view, visit https://gerrit.wikimedia.org/r/250211
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3ddf105d180336b6eb7ae31286221151055e649f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: REL1_26
Gerrit-Owner: Umherirrender <[email protected]>
Gerrit-Reviewer: TheDJ <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
