Esanders has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/253661

Change subject: WindowManager: Fade in overlay after 'setup' not 'ready'
......................................................................

WindowManager: Fade in overlay after 'setup' not 'ready'

This gives users the opportunity to have a slow 'ready'
process while giving the users some visual feedback that
the dialog has been setup and is actually trying to open.

In the future we could render an indeterminate progress
bar if the ready process is taking a long time.

Change-Id: Iac92c89e889dbfc12785daea478fe572f611c48d
---
M src/themes/apex/windows.less
M src/themes/mediawiki/windows.less
2 files changed, 6 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/61/253661/1

diff --git a/src/themes/apex/windows.less b/src/themes/apex/windows.less
index f6a0cc5..247985f 100644
--- a/src/themes/apex/windows.less
+++ b/src/themes/apex/windows.less
@@ -296,10 +296,12 @@
                        .oo-ui-transition(all @medium-ease);
                }
 
-               &.oo-ui-window-ready {
+               &.oo-ui-window-setup {
                        // Fade window overlay
                        opacity: 1;
+               }
 
+               &.oo-ui-window-ready {
                        > .oo-ui-window-frame {
                                // Fade frame
                                opacity: 1;
diff --git a/src/themes/mediawiki/windows.less 
b/src/themes/mediawiki/windows.less
index 059a2e4..cb90d18 100644
--- a/src/themes/mediawiki/windows.less
+++ b/src/themes/mediawiki/windows.less
@@ -275,10 +275,12 @@
                        .oo-ui-transition(all @medium-ease);
                }
 
-               &.oo-ui-window-ready {
+               &.oo-ui-window-setup {
                        // Fade window overlay
                        opacity: 1;
+               }
 
+               &.oo-ui-window-ready {
                        > .oo-ui-window-frame  {
                                // Fade frame
                                opacity: 1;

-- 
To view, visit https://gerrit.wikimedia.org/r/253661
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iac92c89e889dbfc12785daea478fe572f611c48d
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to