jenkins-bot has submitted this change and it was merged.
Change subject: WindowManager: Fade in overlay after 'setup' not 'ready'
......................................................................
WindowManager: Fade in overlay after 'setup' not 'ready'
This gives users the opportunity to have a slow 'ready'
process while giving the users some visual feedback that
the dialog has been setup and is actually trying to open.
In the future we could render an indeterminate progress
bar if the ready process is taking a long time.
Change-Id: Iac92c89e889dbfc12785daea478fe572f611c48d
---
M src/themes/apex/windows.less
M src/themes/mediawiki/windows.less
2 files changed, 6 insertions(+), 2 deletions(-)
Approvals:
Catrope: Looks good to me, approved
Jforrester: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/src/themes/apex/windows.less b/src/themes/apex/windows.less
index f6a0cc5..247985f 100644
--- a/src/themes/apex/windows.less
+++ b/src/themes/apex/windows.less
@@ -296,10 +296,12 @@
.oo-ui-transition(all @medium-ease);
}
- &.oo-ui-window-ready {
+ &.oo-ui-window-setup {
// Fade window overlay
opacity: 1;
+ }
+ &.oo-ui-window-ready {
> .oo-ui-window-frame {
// Fade frame
opacity: 1;
diff --git a/src/themes/mediawiki/windows.less
b/src/themes/mediawiki/windows.less
index 059a2e4..cb90d18 100644
--- a/src/themes/mediawiki/windows.less
+++ b/src/themes/mediawiki/windows.less
@@ -275,10 +275,12 @@
.oo-ui-transition(all @medium-ease);
}
- &.oo-ui-window-ready {
+ &.oo-ui-window-setup {
// Fade window overlay
opacity: 1;
+ }
+ &.oo-ui-window-ready {
> .oo-ui-window-frame {
// Fade frame
opacity: 1;
--
To view, visit https://gerrit.wikimedia.org/r/253661
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iac92c89e889dbfc12785daea478fe572f611c48d
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Ferdbold <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Tchanders <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
