jenkins-bot has submitted this change and it was merged.
Change subject: Add missing #onUpdateState method to OO.ui.Tool subclasses
......................................................................
Add missing #onUpdateState method to OO.ui.Tool subclasses
Bug: T119109
Change-Id: I63c503a165713cf472abaac127803d9192a8878d
---
M resources/mobile.editor.common/EditorOverlayBase.js
M resources/mobile.editor.overlay.withtoolbar/EditorOverlayWithToolbar.js
2 files changed, 12 insertions(+), 0 deletions(-)
Approvals:
Florianschmidtwelzow: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/mobile.editor.common/EditorOverlayBase.js
b/resources/mobile.editor.common/EditorOverlayBase.js
index 4effbc8..a9d22ef 100644
--- a/resources/mobile.editor.common/EditorOverlayBase.js
+++ b/resources/mobile.editor.common/EditorOverlayBase.js
@@ -30,6 +30,12 @@
EditVeTool.prototype.onSelect = function () {
// will be overridden later
};
+ /**
+ * Toolbar update state handler.
+ */
+ EditVeTool.prototype.onUpdateState = function () {
+ // do nothing
+ };
/**
* Base class for EditorOverlay
diff --git
a/resources/mobile.editor.overlay.withtoolbar/EditorOverlayWithToolbar.js
b/resources/mobile.editor.overlay.withtoolbar/EditorOverlayWithToolbar.js
index e069acf..612bfce 100644
--- a/resources/mobile.editor.overlay.withtoolbar/EditorOverlayWithToolbar.js
+++ b/resources/mobile.editor.overlay.withtoolbar/EditorOverlayWithToolbar.js
@@ -67,6 +67,12 @@
// we don't want to leave the button
selected
this.setActive( false );
};
+ /**
+ * Toolbar update state handler.
+ */
+ toolButton.prototype.onUpdateState = function
() {
+ // do nothing
+ };
// set properties
toolButton.static.name = name;
--
To view, visit https://gerrit.wikimedia.org/r/254388
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I63c503a165713cf472abaac127803d9192a8878d
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Florianschmidtwelzow <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
