Paladox has uploaded a new change for review.
https://gerrit.wikimedia.org/r/260032
Change subject: Fix double slashes in redirect script for gerrit
......................................................................
Fix double slashes in redirect script for gerrit
Change-Id: Icf10df1e4f161b4862db17faa32b24d32da8c0c5
---
M GerritProjectController.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/phabricator/extensions
refs/changes/32/260032/1
diff --git a/GerritProjectController.php b/GerritProjectController.php
index bf6d5c9..636cb05 100644
--- a/GerritProjectController.php
+++ b/GerritProjectController.php
@@ -1324,9 +1324,9 @@
// get rid of refs/heads prefix
$branch = str_replace('refs/heads', '', $branch);
$branch = trim($branch, '/');
- $branch = str_replace('HEAD', '');
// double encode any forward slashes in ref.
$branch = str_replace('/', '%252F', $branch);
+ $branch = str_replace('HEAD', '');
return id(new AphrontRedirectResponse())
->setURI("/diffusion/$CALLSIGN/browse/$branch/");
--
To view, visit https://gerrit.wikimedia.org/r/260032
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icf10df1e4f161b4862db17faa32b24d32da8c0c5
Gerrit-PatchSet: 1
Gerrit-Project: phabricator/extensions
Gerrit-Branch: master
Gerrit-Owner: Paladox <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
