20after4 has uploaded a new change for review.
https://gerrit.wikimedia.org/r/260034
Change subject: Fix missing arg to str_replace
......................................................................
Fix missing arg to str_replace
Gotta pass the string... Duh.
Change-Id: I01148b21098dfa512b17f2d636937c1ee1fb10b3
---
M GerritProjectController.php
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/phabricator/extensions
refs/changes/34/260034/1
diff --git a/GerritProjectController.php b/GerritProjectController.php
index 2dc27f3..2c0762d 100644
--- a/GerritProjectController.php
+++ b/GerritProjectController.php
@@ -1324,10 +1324,10 @@
// get rid of refs/heads prefix
$branch = str_replace('refs/heads', '', $branch);
$branch = trim($branch, '/');
- $branch = str_replace('HEAD', '');
+ $branch = str_replace('HEAD', '', $branch);
// double encode any forward slashes in ref.
$branch = str_replace('/', '%252F', $branch);
- if (strlen($branch)==0){
+ if (strlen($branch)==0) {
return id(new AphrontRedirectResponse())
->setURI("/diffusion/$CALLSIGN/browse/");
} else {
--
To view, visit https://gerrit.wikimedia.org/r/260034
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I01148b21098dfa512b17f2d636937c1ee1fb10b3
Gerrit-PatchSet: 1
Gerrit-Project: phabricator/extensions
Gerrit-Branch: master
Gerrit-Owner: 20after4 <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
