Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/261182
Change subject: Add missing local keywords
......................................................................
Add missing local keywords
Change-Id: I48b8bbcdc8440cde0a2fee6e1f3b43e5ba37d4b8
---
M includes/Lua/EntityRenderer.lua
1 file changed, 11 insertions(+), 14 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ArticlePlaceholder
refs/changes/82/261182/1
diff --git a/includes/Lua/EntityRenderer.lua b/includes/Lua/EntityRenderer.lua
index 3b1b454..46f3bd6 100644
--- a/includes/Lua/EntityRenderer.lua
+++ b/includes/Lua/EntityRenderer.lua
@@ -5,8 +5,6 @@
local entityrenderer = {}
-local libraryUtil = require( 'libraryUtil' )
-
entityrenderer.imageProperty = 'P6'
local identifierProperties = require( 'Identifier' )
@@ -24,7 +22,7 @@
-- @param string entityId
-- @return string label or entityId if no label available
local labelRenderer = function( entityId )
- label = mw.wikibase.label( entityId )
+ local label = mw.wikibase.label( entityId )
if label == nil then
label = entityId
end
@@ -44,9 +42,9 @@
-- @param table snaks
-- @return String result
local snaksRenderer = function( snaks )
- result = ''
+ local result = ''
if snaks ~= nil and type( snaks ) == 'table' then
- result = result .. mw.wikibase.renderSnaks( snaks )
+ result = result .. mw.wikibase.renderSnaks( snaks )
end
return result
end
@@ -61,7 +59,7 @@
local i = 1
while referenceSnak[i] do
for k, v in pairs( referenceSnak[i]['snaks'] ) do
- result = result .. '<p><b>' .. labelRenderer( k ) .. '</b>: '
+ result = result .. '<p><b>' .. labelRenderer( k ) .. '</b>: '
result = result .. snaksRenderer( v ) .. '</p>'
end
i = i + 1
@@ -78,7 +76,7 @@
if qualifierSnak ~= nil then
result = result .. '<h4>' .. mw.message.new(
'articleplaceholder-abouttopic-lua-qualifier' ):plain() .. '</h4>'
for key, value in pairs(qualifierSnak) do
- result = result .. '<p><b>' .. labelRenderer( key ) .. '</b>: '
+ result = result .. '<p><b>' .. labelRenderer( key ) .. '</b>: '
result = result .. snaksRenderer( value ) .. '</p>'
end
end
@@ -89,7 +87,6 @@
-- @param String propertyId
-- @return String renderedImage
local imageStatementRenderer = function( statement, orientationImage )
- local result = ''
local reference = ''
local qualifier = ''
local image = ''
@@ -104,8 +101,8 @@
end
end
end
- result = '[[File:' .. image .. '|thumb|' .. orientationImage .. '|200px]]'
- result = result .. qualifier .. reference
+ local result = '[[File:' .. image .. '|thumb|' .. orientationImage ..
'|200px]]'
+ result = result .. qualifier .. reference
return result
end
@@ -172,7 +169,7 @@
if identifierList ~= nil and identifierList ~= '' then
local div = '<div class="articleplaceholder-identifierlist">'
identifierList = div .. '<h1>' .. mw.message.new(
'articleplaceholder-abouttopic-lua-identifier' ):plain() .. '</h1>' ..
identifierList
- return identifierList .. '</div>'
+ return identifierList .. '</div>'
end
return ''
end
@@ -200,8 +197,8 @@
-- @param String propertyId
-- @return String renderedImage
local topImageRenderer = function( entity, propertyId, orientationImage )
- renderedImage = ''
- imageName = entity:formatPropertyValues( propertyId ).value
+ local renderedImage = ''
+ local imageName = entity:formatPropertyValues( propertyId ).value
if imageName ~= '' and imageName ~= nil then
renderedImage = '[[File:' .. imageName .. '|thumb|' .. orientationImage ..
']]'
end
@@ -331,7 +328,7 @@
entityrenderer.setIdentifierListRenderer = function( newIdentifierListRenderer
)
util.checkType( 'setIdentifierListRenderer', 1, newIdentifierListRenderer,
'function' )
- identifierListRenderer = newIdentifierListRenderer
+ identifierListRenderer = newIdentifierListRenderer
end
entityrenderer.getStatementListRenderer = function()
--
To view, visit https://gerrit.wikimedia.org/r/261182
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I48b8bbcdc8440cde0a2fee6e1f3b43e5ba37d4b8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ArticlePlaceholder
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
