Legoktm has uploaded a new change for review.
https://gerrit.wikimedia.org/r/261875
Change subject: Fix &diff=0 being treated as a non-diff page
......................................................................
Fix &diff=0 being treated as a non-diff page
Change-Id: Iec6d08bff3a2c6976300a910f42b173efcaa2104
---
M includes/WikidataPageBanner.hooks.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikidataPageBanner
refs/changes/75/261875/1
diff --git a/includes/WikidataPageBanner.hooks.php
b/includes/WikidataPageBanner.hooks.php
index f4fa63a..195bb30 100644
--- a/includes/WikidataPageBanner.hooks.php
+++ b/includes/WikidataPageBanner.hooks.php
@@ -83,7 +83,7 @@
}
$config = WikidataPageBannerFunctions::getWPBConfig();
$title = $out->getTitle();
- $isDiff = $out->getRequest()->getVal( 'diff' );
+ $isDiff = $out->getRequest()->getVal( 'diff', false ) !== false;
$wpbFunctionsClass = self::$wpbFunctionsClass;
// if banner-options are set and not a diff page, add banner
anyway
--
To view, visit https://gerrit.wikimedia.org/r/261875
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iec6d08bff3a2c6976300a910f42b173efcaa2104
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikidataPageBanner
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
