jenkins-bot has submitted this change and it was merged.
Change subject: Fix &diff=0 being treated as a non-diff page
......................................................................
Fix &diff=0 being treated as a non-diff page
Change-Id: Iec6d08bff3a2c6976300a910f42b173efcaa2104
---
M includes/WikidataPageBanner.hooks.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jdlrobson: Looks good to me, approved
Thiemo Mättig (WMDE): Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/includes/WikidataPageBanner.hooks.php
b/includes/WikidataPageBanner.hooks.php
index f4fa63a..283c5c0 100644
--- a/includes/WikidataPageBanner.hooks.php
+++ b/includes/WikidataPageBanner.hooks.php
@@ -83,7 +83,7 @@
}
$config = WikidataPageBannerFunctions::getWPBConfig();
$title = $out->getTitle();
- $isDiff = $out->getRequest()->getVal( 'diff' );
+ $isDiff = $out->getRequest()->getCheck( 'diff' );
$wpbFunctionsClass = self::$wpbFunctionsClass;
// if banner-options are set and not a diff page, add banner
anyway
--
To view, visit https://gerrit.wikimedia.org/r/261875
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iec6d08bff3a2c6976300a910f42b173efcaa2104
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/WikidataPageBanner
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Reedy <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
