jenkins-bot has submitted this change and it was merged.
Change subject: Properly document redirect mode as string instead of mixed
......................................................................
Properly document redirect mode as string instead of mixed
Change-Id: Iba2860ee7488364b8e5ac6eade4b26f47143bec6
---
M repo/includes/store/EntityPerPage.php
M repo/includes/store/sql/EntityPerPageIdPager.php
M repo/includes/store/sql/EntityPerPageTable.php
M repo/tests/phpunit/MockEntityPerPage.php
4 files changed, 5 insertions(+), 5 deletions(-)
Approvals:
Hoo man: Looks good to me, approved
jenkins-bot: Verified
diff --git a/repo/includes/store/EntityPerPage.php
b/repo/includes/store/EntityPerPage.php
index 84175f8..e8233b4 100644
--- a/repo/includes/store/EntityPerPage.php
+++ b/repo/includes/store/EntityPerPage.php
@@ -64,7 +64,7 @@
* @param null|string $entityType The entity type to look for.
* @param int $limit The maximum number of IDs to return.
* @param EntityId|null $after Only return entities with IDs greater
than this.
- * @param mixed $redirects A XXX_REDIRECTS constant (default is
NO_REDIRECTS).
+ * @param string $redirects A XXX_REDIRECTS constant (default is
NO_REDIRECTS).
*
* @return EntityId[]
*/
diff --git a/repo/includes/store/sql/EntityPerPageIdPager.php
b/repo/includes/store/sql/EntityPerPageIdPager.php
index 60ad2df..69ba2d7 100644
--- a/repo/includes/store/sql/EntityPerPageIdPager.php
+++ b/repo/includes/store/sql/EntityPerPageIdPager.php
@@ -31,14 +31,14 @@
private $position = null;
/**
- * @var mixed
+ * @var string
*/
private $redirectMode;
/**
* @param EntityPerPage $entityPerPage
* @param null|string $entityType The desired entity type, or null for
any type.
- * @param mixed $redirectMode A EntityPerPage::XXX_REDIRECTS constant
(default is NO_REDIRECTS).
+ * @param string $redirectMode A EntityPerPage::XXX_REDIRECTS constant
(default is NO_REDIRECTS).
*/
public function __construct( EntityPerPage $entityPerPage, $entityType
= null, $redirectMode = EntityPerPage::NO_REDIRECTS ) {
$this->entityPerPage = $entityPerPage;
diff --git a/repo/includes/store/sql/EntityPerPageTable.php
b/repo/includes/store/sql/EntityPerPageTable.php
index b70537c..94b7b15 100644
--- a/repo/includes/store/sql/EntityPerPageTable.php
+++ b/repo/includes/store/sql/EntityPerPageTable.php
@@ -320,7 +320,7 @@
* @param null|string $entityType The entity type to look for.
* @param int $limit The maximum number of IDs to return.
* @param EntityId|null $after Only return entities with IDs greater
than this.
- * @param mixed $redirects A XXX_REDIRECTS constant (default is
NO_REDIRECTS).
+ * @param string $redirects A XXX_REDIRECTS constant (default is
NO_REDIRECTS).
*
* @throws InvalidArgumentException
* @return EntityId[]
diff --git a/repo/tests/phpunit/MockEntityPerPage.php
b/repo/tests/phpunit/MockEntityPerPage.php
index c6cd937..87784fb 100644
--- a/repo/tests/phpunit/MockEntityPerPage.php
+++ b/repo/tests/phpunit/MockEntityPerPage.php
@@ -58,7 +58,7 @@
* @param null|string $entityType The entity type to look for.
* @param int $limit The maximum number of IDs to return.
* @param EntityId|null $after Only return entities with IDs greater
than this.
- * @param mixed $redirects A XXX_REDIRECTS constant (default is
NO_REDIRECTS).
+ * @param string $redirects A XXX_REDIRECTS constant (default is
NO_REDIRECTS).
*
* @return EntityId[]
*/
--
To view, visit https://gerrit.wikimedia.org/r/263059
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iba2860ee7488364b8e5ac6eade4b26f47143bec6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: Bene <[email protected]>
Gerrit-Reviewer: Daniel Kinzler <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
